fix logging in self-test ending prematurely

Author: CamDavidsonPilon

CHANGELOG.md

@@ -13,6 +13,10 @@
 #### Breaking changes
  - Moved Self-test to Inventory page. Pioreactors no longer need to be assigned to an experiment to run self-test.
  - Removed `/api/workers/<pioreactor_unit>/configuration`; use `/api/units/<pioreactor_unit>/configuration`.
+ - self-test logs are now part of "$experiment"
+#### bug fixes
+
+ - fix logging prematurely closing for self-tests
 
 ### 25.12.10
 

core/pioreactor/actions/self_test.py

@@ -704,6 +704,7 @@ def click_self_test(k: Optional[str], retry_failed: bool) -> int:
         elif count_failures > 0:
             logger.info(f"{count_failures} failed test{'s' if count_failures > 1 else ''} ❌")
 
+        print(count_tested, count_failures)
         # clear my retained messages
         prune_retained_messages(f"pioreactor/{unit}/{testing_experiment}/#")
 

core/pioreactor/background_jobs/base.py

@@ -86,20 +86,23 @@ class LoggerMixin:
     def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         self._logger = None
+        self._external_logger = False
 
     def add_external_logger(self, logger) -> None:
         self._logger = logger
+        self._external_logger = True
 
     @property
     def logger(self):
         if self._logger is None:
             self._logger = create_logger(
                 name=self._logger_name if hasattr(self, "_logger_name") else self.__class__.__name__
             )
+            self._external_logger = False
         return self._logger
 
     def __del__(self):
-        if self._logger:
+        if self._logger and not self._external_logger:
             self._logger.clean_up()