this fixes the db is lcoked errors

Author: CamDavidsonPilon

pioreactor/tests/test_utils.py

@@ -74,6 +74,19 @@ def test_caches_will_delete_when_asked() -> None:
         assert "test" not in cache
 
 
+def test_caches_pop() -> None:
+    with local_intermittent_storage("test") as cache:
+        cache.empty()
+
+    with local_intermittent_storage("test") as cache:
+        cache["A"] = "1"
+
+    with local_intermittent_storage("test") as cache:
+        assert cache.pop("A") == "1"
+        assert cache.pop("B") is None
+        assert cache.pop("C", default=3) == 3
+
+
 def test_caches_can_have_tuple_or_singleton_keys() -> None:
     with local_persistent_storage("test_caches_can_have_tuple_keys") as c:
         c[(1, 2)] = 1

pioreactor/utils/__init__.py

@@ -348,7 +348,7 @@ def __enter__(self):
             PRAGMA cache_size = -4000;
         """
         )
-        self.cursor.execute("BEGIN")
+        self.cursor.execute("BEGIN IMMEDIATE")
         self._initialize_table()
         return self
 
@@ -394,9 +394,8 @@ def iterkeys(self):
         return (self.convert_key(row[0]) for row in self.cursor.fetchall())
 
     def pop(self, key, default=None):
-        self.cursor.execute(f"SELECT value FROM {self.table_name} WHERE key = ?", (key,))
+        self.cursor.execute(f"DELETE FROM {self.table_name} WHERE key = ? RETURNING value", (key,))
         result = self.cursor.fetchone()
-        self.cursor.execute(f"DELETE FROM {self.table_name} WHERE key = ?", (key,))
 
         if result is None:
             return default
@@ -647,6 +646,7 @@ def __init__(self) -> None:
         )
         self.cursor = self.conn.cursor()
         self._create_tables()
+        self.cursor.execute("BEGIN IMMEDIATE")
 
     def _create_tables(self) -> None:
         # TODO: add a created_at, updated_at to pio_job_published_settings

pytest.ini

@@ -1,3 +1,3 @@
 [pytest]
 testpaths=pioreactor/tests/
-addopts = --random-order
+addopts = --random-order -s -vv