Refactor Pingback actions to simplify data handling and improve code consistency. Updated Add, Create, Remove, and Update Subscriber actions to use a unified data structure. Introduced parseCustomFields utility for better custom fields management.

Author: luancazarine

components/pingback/actions/add-subscriber-to-segmentation-lists/add-subscriber-to-segmentation-lists.mjs

@@ -1,8 +1,7 @@
-import { defineAction } from "@pipedream/types";
 import { parseObject } from "../../common/utils.mjs";
 import pingback from "../../pingback.app.mjs";
 
-export default defineAction({
+export default {
   name: "Add Subscriber To Segmentation Lists",
   description: "Add a subscriber to segmentation lists by email [See the documentation](https://developer.pingback.com/docs/api/add-subscriber-to-segment)",
   key: "pingback-add-subscriber-to-segmentation-lists",
@@ -35,4 +34,4 @@ export default defineAction({
     $.export("$summary", `Subscriber ${this.email} added to segmentation list(s) successfully`);
     return response;
   },
-});
+};

components/pingback/actions/create-subscriber/create-subscriber.mjs

@@ -1,4 +1,7 @@
-import { parseObject } from "../../common/utils.mjs";
+import {
+  parseCustomFields,
+  parseObject,
+} from "../../common/utils.mjs";
 import pingback from "../../pingback.app.mjs";
 
 export default {
@@ -47,22 +50,19 @@ export default {
     },
   },
   async run({ $ }) {
+    const data  = {
+      email: this.email,
+      phone: this.phone,
+      name: this.name,
+      status: this.status,
+      segmentationLists: parseObject(this.segmentationLists),
+    };
+
+    data.customFields = parseCustomFields(this.customFields);
+
     const response = await this.pingback.createSubscriber({
       $,
-      data: {
-        email: this.email,
-        phone: this.phone,
-        name: this.name,
-        status: this.status,
-        customFields: Object.entries(parseObject(this.customFields))?.map(([
-          key,
-          value,
-        ]) => ({
-          label: key,
-          value,
-        })),
-        segmentationLists: parseObject(this.segmentationLists),
-      },
+      data,
     });
 
     $.export("$summary", `Subscriber created successfully with ID: ${response.data.data.id}`);

components/pingback/actions/remove-subscriber-from-segmentation-list/remove-subscriber-from-segmentation-list.mjs

@@ -1,7 +1,6 @@
-import { defineAction } from "@pipedream/types";
 import pingback from "../../pingback.app.mjs";
 
-export default defineAction({
+export default {
   name: "Remove Subscriber From Segmentation List",
   description: "Remove a subscriber from a segmentation list by email [See the documentation](https://developer.pingback.com/docs/api/remove-subscriber-from-segment)",
   key: "pingback-remove-subscriber-from-segmentation-list",
@@ -18,9 +17,11 @@ export default defineAction({
     segmentationListId: {
       propDefinition: [
         pingback,
-        "segmentationListId",
+        "segmentationLists",
       ],
-      type: "string",
+      type: "string[]",
+      label: "Segmentation Lists",
+      description: "Segmentation list ID to remove the subscriber from. You can get the ID by clicking audience and lists at Pingback dashboard.",
     },
   },
   async run({ $ }) {
@@ -33,4 +34,4 @@ export default defineAction({
     $.export("$summary", `Subscriber ${this.email} removed from segmentation list ${this.segmentationListId} successfully`);
     return response;
   },
-});
+};

components/pingback/actions/update-subscriber/update-subscriber.mjs

@@ -1,8 +1,7 @@
-import { defineAction } from "@pipedream/types";
-import { parseObject } from "../../common/utils.mjs";
+import { parseCustomFields } from "../../common/utils.mjs";
 import pingback from "../../pingback.app.mjs";
 
-export default defineAction({
+export default {
   name: "Update Subscriber",
   description: "Update a specific subscriber by email [See the documentation](https://developer.pingback.com/docs/api/update-subscriber)",
   key: "pingback-update-subscriber",
@@ -42,24 +41,21 @@ export default defineAction({
     },
   },
   async run({ $ }) {
+    const data = {
+      phone: this.phone,
+      name: this.name,
+      status: this.status,
+    };
+
+    data.customFields = parseCustomFields(this.customFields);
+
     const response = await this.pingback.updateSubscriber({
       $,
       email: this.email,
-      data: {
-        phone: this.phone,
-        name: this.name,
-        status: this.status,
-        customFields: Object.entries(parseObject(this.customFields))?.map(([
-          key,
-          value,
-        ]) => ({
-          label: key,
-          value,
-        })),
-      },
+      data,
     });
 
     $.export("$summary", `Subscriber updated successfully with ID: ${response.data.data.id}`);
     return response;
   },
-});
+};

components/pingback/common/utils.mjs

@@ -22,3 +22,16 @@ export const parseObject = (obj) => {
   }
   return obj;
 };
+
+export const parseCustomFields = (customFields) => {
+  const parsedCustomFields = Object.entries(parseObject(customFields) || {});
+  if (parsedCustomFields.length) {
+    return parsedCustomFields.map(([
+      key,
+      value,
+    ]) => ({
+      label: key,
+      value,
+    }));
+  }
+};