Remove unused async code

Author: adolfo-pd

packages/connect-react/examples/nextjs/package-lock.json

@@ -4,7 +4,6 @@
 // operations, like connecting accounts via Pipedream Connect. See the server/
 // directory for the server client.
 
-import { BrowserAsyncResponseManager } from "./async.js";
 import {
   AccountsRequestResponse,
   BaseClient,
@@ -133,7 +132,6 @@ export function createFrontendClient(opts: CreateBrowserClientOpts = {}) {
  * A client for interacting with the Pipedream Connect API from the browser.
  */
 export class BrowserClient extends BaseClient {
-  protected override asyncResponseManager: BrowserAsyncResponseManager;
   private baseURL: string;
   private iframeURL: string;
   private iframe?: HTMLIFrameElement;
@@ -155,10 +153,6 @@ export class BrowserClient extends BaseClient {
     this.iframeURL = `${this.baseURL}/_static/connect.html`;
     this.tokenCallback = opts.tokenCallback;
     this.externalUserId = opts.externalUserId;
-    this.asyncResponseManager = new BrowserAsyncResponseManager({
-      apiHost: this.apiHost,
-      getConnectToken: () => this.token(),
-    });
   }
 
   private async token() {

packages/sdk/src/browser/async.ts

@@ -8,7 +8,6 @@ import {
 import {
   Account, BaseClient, type AppInfo, type ConnectTokenResponse,
 } from "../shared";
-import { ServerAsyncResponseManager } from "./async";
 export * from "../shared";
 
 /**
@@ -137,7 +136,6 @@ export function createBackendClient(opts: BackendClientOpts) {
  * A client for interacting with the Pipedream Connect API on the server-side.
  */
 export class BackendClient extends BaseClient {
-  protected override asyncResponseManager: ServerAsyncResponseManager;
   private oauthClient: ClientCredentials;
   private oauthToken?: AccessToken;
   protected projectId: string;
@@ -155,18 +153,6 @@ export class BackendClient extends BaseClient {
     this.projectId = opts.projectId;
 
     this.oauthClient = this.newOauthClient(opts.credentials, this.baseApiUrl);
-    this.asyncResponseManager = new ServerAsyncResponseManager({
-      apiHost: this.apiHost,
-      getOauthToken: async () => {
-        await this.ensureValidOauthToken();
-        return this.oauthToken as AccessToken;
-      },
-      getProjectId: () => {
-        if (!this.projectId)
-          throw "Attempted to connect to websocket without a valid Project id";
-        return this.projectId;
-      },
-    });
   }
 
   private ensureValidEnvironment(environment?: string) {

packages/sdk/src/browser/index.ts

@@ -1,9 +1,4 @@
 // This code is meant to be shared between the browser and server.
-import type {
-  AsyncResponse,
-  AsyncErrorResponse,
-  AsyncResponseManager,
-} from "./async.js";
 import type {
   ConfigurableProps,
   ConfiguredProps,
@@ -580,7 +575,6 @@ export interface AsyncRequestOptions extends RequestOptions {
 export abstract class BaseClient {
   version = sdkVersion;
   protected apiHost: string;
-  protected abstract asyncResponseManager: AsyncResponseManager;
   protected readonly baseApiUrl: string;
   protected environment: string;
   protected projectId?: string;
@@ -744,35 +738,6 @@ export abstract class BaseClient {
     return this.makeAuthorizedRequest(fullPath, opts);
   }
 
-  /**
-   * Makes a request to the Connect API using Connect authorization.
-   * This version makes an asynchronous request, fulfilled via Websocket.
-   *
-   * @template T - The expected response type.
-   * @param path - The API endpoint path.
-   * @param opts - The options for the request.
-   * @returns A promise resolving to the API response.
-   */
-  protected async makeConnectRequestAsync<T extends object>(
-    path: string,
-    opts: AsyncRequestOptions,
-  ): Promise<T> {
-    await this.asyncResponseManager.ensureConnected();
-    const data = await this.makeConnectRequest<
-      AsyncResponse | AsyncErrorResponse | T
-    >(path, opts);
-    if ("errors" in data && data.errors.length) {
-      throw new Error(data.errors[0]);
-    }
-    if ("async_handle" in data && data.async_handle) {
-      const result = await this.asyncResponseManager.waitFor<T>(
-        data.async_handle,
-      );
-      return result;
-    }
-    return data as T;
-  }
-
   /**
    * Retrieves the list of accounts associated with the project.
    *
@@ -956,14 +921,13 @@ export abstract class BaseClient {
       : componentId;
 
     const body = {
-      async_handle: this.asyncResponseManager.createAsyncHandle(),
       external_user_id: externalUserId,
       id,
       prop_name: opts.propName,
       configured_props: opts.configuredProps,
       dynamic_props_id: opts.dynamicPropsId,
     };
-    return this.makeConnectRequestAsync<ConfigureComponentResponse>("/components/configure", {
+    return this.makeConnectRequest<ConfigureComponentResponse>("/components/configure", {
       method: "POST",
       body,
     });
@@ -1013,14 +977,13 @@ export abstract class BaseClient {
 
     // RpcActionReloadPropsInput
     const body = {
-      async_handle: this.asyncResponseManager.createAsyncHandle(),
       external_user_id: externalUserId,
       id,
       configured_props: opts.configuredProps,
       dynamic_props_id: opts.dynamicPropsId,
     };
 
-    return this.makeConnectRequestAsync<ConfiguredProps<ConfigurableProps>>(
+    return this.makeConnectRequest<ConfiguredProps<ConfigurableProps>>(
       "/components/props", {
       // TODO trigger
         method: "POST",
@@ -1072,13 +1035,12 @@ export abstract class BaseClient {
       : actionId;
 
     const body = {
-      async_handle: this.asyncResponseManager.createAsyncHandle(),
       external_user_id: externalUserId,
       id,
       configured_props: opts.configuredProps,
       dynamic_props_id: opts.dynamicPropsId,
     };
-    return this.makeConnectRequestAsync<RunActionResponse>("/actions/run", {
+    return this.makeConnectRequest<RunActionResponse>("/actions/run", {
       method: "POST",
       body,
     });
@@ -1126,14 +1088,13 @@ export abstract class BaseClient {
       : triggerId;
 
     const body = {
-      async_handle: this.asyncResponseManager.createAsyncHandle(),
       external_user_id: externalUserId,
       id,
       configured_props: opts.configuredProps,
       dynamic_props_id: opts.dynamicPropsId,
       webhook_url: opts.webhookUrl,
     };
-    return this.makeConnectRequestAsync<V1DeployedComponent>("/triggers/deploy", {
+    return this.makeConnectRequest<V1DeployedComponent>("/triggers/deploy", {
       method: "POST",
       body,
     });