Massive improvements to props supporting async options

GTFalcao · GTFalcao · commit 1b4822b32cbc · 2025-02-11T00:49:53.000-03:00
diff --git a/components/monday/actions/common/common-create-item.mjs b/components/monday/actions/common/common-create-item.mjs
@@ -14,7 +14,7 @@ export default {
         }),
       ],
       type: "string[]",
-      description: "Select which item columns to set values for.",
+      description: "Select which item columns to set values for",
       reloadProps: true,
     },
   },
@@ -26,13 +26,14 @@ export default {
     const columnData = await this.monday.listColumns({
       boardId: +this.boardId,
     });
+    console.log(columnData);
     for (const column of this.columns) {
       let description, options;
       options = getColumnOptions(columnData, column);
       if (column === "person") {
-        description = "The ID of a person/user.";
+        description = "The ID of a person/user";
       } else if (column === "date4") {
-        description = "A date string in `YYYY-MM-DD` format, e.g. `2022-09-02`.";
+        description = "A date string in `YYYY-MM-DD` format, e.g. `2022-09-02`";
       } else if (options) {
         description = `Select a value from the list for column "${column}".`;
       } else {
diff --git a/components/monday/actions/create-column/create-column.mjs b/components/monday/actions/create-column/create-column.mjs
@@ -1,12 +1,13 @@
 import constants from "../../common/constants.mjs";
 import monday from "../../monday.app.mjs";
+import { ConfigurationError } from "@pipedream/platform";
 
 export default {
   key: "monday-create-column",
   name: "Create Column",
   description: "Creates a column. [See the documentation](https://developer.monday.com/api-reference/reference/columns#create-a-column)",
   type: "action",
-  version: "0.0.9",
+  version: "0.1.0",
   props: {
     monday,
     boardId: {
@@ -18,45 +19,64 @@ export default {
     title: {
       type: "string",
       label: "Title",
-      description: "The title of the new column.",
+      description: "The title of the new column",
     },
     columnType: {
       type: "string",
       label: "Column Type",
-      description: "The type of the new column.",
+      description: "The type of the new column",
       options: constants.COLUMN_TYPE_OPTIONS,
       reloadProps: true,
     },
     description: {
       type: "string",
       label: "Description",
-      description: "The description of the new column.",
+      description: "The description of the new column",
       optional: true,
     },
   },
   async additionalProps() {
     const props = {};
-    const defaults = {
-      type: "string",
-      label: "Defaults",
-      description: "The new column's defaults. For use with column types `status` or `dropdown`. [See the documentation](https://developer.monday.com/api-reference/reference/columns#create-a-status-or-dropdown-column-with-custom-labels) for more information.",
-      optional: true,
-    };
-    if (this.columnType === "status") {
-      props.defaults = {
-        ...defaults,
-        default: "{\"labels\":{\"1\":\"Option1\",\"2\":\"Option2\",\"3\":\"Option3\",\"4\": \"Option4\"}}",
-      };
-    }
-    if (this.columnType === "dropdown") {
+    if ([
+      "status",
+      "dropdown",
+    ].includes(this.columnType)) {
       props.defaults = {
-        ...defaults,
-        default: "{\"settings\":{\"labels\":[{\"id\":1,\"name\":\"Option1\"}, {\"id\":2,\"name\":\"Option2\"}, {\"id\":3,\"name\":\"Option3\"}]}}",
+        type: "string",
+        label: "Custom Labels (Defaults)",
+        description: "The new column's custom labels (defaults). For use with column types `status` or `dropdown`. Should be an object in the format `{ \"1\": \"Technology\", \"2\": \"Marketing\" }` where each key is the label ID and each value is the label text. [See the documentation](https://developer.monday.com/api-reference/reference/columns#create-a-status-or-dropdown-column-with-custom-labels) for more information.",
+        optional: true,
       };
     }
     return props;
   },
   async run({ $ }) {
+    let { defaults } = this;
+    if (defaults) {
+      try {
+        if (this.columnType === "status") {
+          defaults = JSON.stringify({
+            labels: JSON.parse(defaults),
+          });
+        } else if (this.columnType === "dropdown") {
+          const obj = JSON.parse(defaults);
+          defaults = JSON.stringify({
+            settings: {
+              labels: Object.entries(obj).map(([
+                id,
+                name,
+              ]) => ({
+                id: Number(id),
+                name,
+              })),
+            },
+          });
+        }
+      } catch (err) {
+        throw new ConfigurationError(`Error parsing \`Custom Labels\` as JSON: "${err}"`);
+      }
+    }
+    $.export("debug", defaults);
     const {
       data,
       errors,
@@ -66,11 +86,7 @@ export default {
         boardId: +this.boardId,
         title: this.title,
         columnType: this.columnType,
-        defaults: this.defaults
-          ? typeof this.defaults !== "string"
-            ? JSON.stringify(this.defaults)
-            : this.defaults
-          : undefined,
+        defaults,
         description: this.description,
       });
 
diff --git a/components/monday/actions/create-item/create-item.mjs b/components/monday/actions/create-item/create-item.mjs
@@ -8,7 +8,7 @@ export default {
   name: "Create Item",
   description: "Creates an item. [See the documentation](https://developer.monday.com/api-reference/reference/items#create-an-item)",
   type: "action",
-  version: "0.1.0",
+  version: "0.1.{{ts}}",
   props: {
     monday,
     boardId: {
diff --git a/components/monday/actions/create-subitem/create-subitem.mjs b/components/monday/actions/create-subitem/create-subitem.mjs
@@ -26,14 +26,14 @@ export default {
         }),
       ],
       optional: false,
-      description: "Select a parent item or provide an item ID.",
+      description: "Select a parent item or provide an item ID",
     },
     itemName: {
       propDefinition: [
         monday,
         "itemName",
       ],
-      description: "The new subitem's name.",
+      description: "The new subitem's name",
     },
     ...commonCreateItem.props,
   },
diff --git a/components/monday/actions/create-update/create-update.mjs b/components/monday/actions/create-update/create-update.mjs
@@ -33,7 +33,7 @@ export default {
     },
     parentId: {
       label: "Parent Update ID",
-      description: "Select a parent update or provide an update ID.",
+      description: "Select a parent update or provide an update ID",
       propDefinition: [
         monday,
         "updateId",
diff --git a/components/monday/actions/get-column-values/get-column-values.mjs b/components/monday/actions/get-column-values/get-column-values.mjs
@@ -29,7 +29,7 @@ export default {
       ],
       type: "string[]",
       label: "Columns",
-      description: "Select the column(s) to return data from.",
+      description: "Select the column(s) to return data from",
       optional: true,
     },
   },
diff --git a/components/monday/actions/get-items-by-column-value/get-items-by-column-value.mjs b/components/monday/actions/get-items-by-column-value/get-items-by-column-value.mjs
@@ -35,7 +35,7 @@ export default {
         label: "Value",
         description: `The value to search for.${options
           ? ""
-          : " [See the documentation](https://developer.monday.com/api-reference/reference/items-page-by-column-values#supported-and-unsupported-columns) for additional information about column values."} `,
+          : " [See the documentation](https://developer.monday.com/api-reference/reference/items-page-by-column-values#supported-and-unsupported-columns) for additional information about column values"} `,
         options,
       },
     };
diff --git a/components/monday/actions/update-column-values/update-column-values.mjs b/components/monday/actions/update-column-values/update-column-values.mjs
@@ -16,7 +16,7 @@ export default {
     updateInfoBox: {
       type: "alert",
       alertType: "info",
-      content: "See the [Column types reference](https://developer.monday.com/api-reference/reference/column-types-reference) to find the proper data structures for supported column types.",
+      content: "See the [Column types reference](https://developer.monday.com/api-reference/reference/column-types-reference) to find the proper data structures for supported column types",
     },
     boardId: {
       ...common.props.boardId,
@@ -50,7 +50,7 @@ export default {
           options: getColumnOptions(columns, id),
         };
         if (column.type === "file") {
-          props[column.id].description += ". The path to a file in the `/tmp` directory. [See the documentation on working with files](https://pipedream.com/docs/code/nodejs/working-with-files/#writing-a-file-to-tmp).";
+          props[column.id].description += ". The path to a file in the `/tmp` directory. [See the documentation on working with files](https://pipedream.com/docs/code/nodejs/working-with-files/#writing-a-file-to-tmp)";
         }
       }
     }
diff --git a/components/monday/common/utils.mjs b/components/monday/common/utils.mjs
@@ -33,17 +33,25 @@ export function getColumnOptions(allColumnData, columnId) {
   )?.settings_str;
   if (columnOptions) {
     try {
-      return Object.entries(JSON.parse(columnOptions).labels).map(
-        ([
-          value,
-          label,
-        ]) => ({
-          label: label !== ""
-            ? label
-            : value,
-          value,
-        }),
-      );
+      const labels = JSON.parse(columnOptions).labels;
+      return Array.isArray(labels)
+        ? labels.map(({
+          id, name,
+        }) => ({
+          label: name,
+          value: id.toString(),
+        }))
+        : Object.entries(labels).map(
+          ([
+            value,
+            label,
+          ]) => ({
+            label: label !== ""
+              ? label
+              : value,
+            value,
+          }),
+        );
     } catch (err) {
       console.log(`Error parsing options for column "${columnId}": ${err}`);
     }
diff --git a/components/monday/monday.app.mjs b/components/monday/monday.app.mjs
@@ -13,7 +13,7 @@ export default {
     boardId: {
       type: "string",
       label: "Board ID",
-      description: "Select a board, or provide a board ID.",
+      description: "Select a board, or provide a board ID",
       async options({ page }) {
         return this.listBoardsOptions({
           page: page + 1,
@@ -34,7 +34,7 @@ export default {
     folderId: {
       type: "integer",
       label: "Folder ID",
-      description: "Optionally select a folder to create the board in, or provide a folder ID.",
+      description: "Optionally select a folder to create the board in, or provide a folder ID",
       optional: true,
       async options({ workspaceId }) {
         return this.listFolderOptions({
@@ -45,7 +45,7 @@ export default {
     workspaceId: {
       type: "integer",
       label: "Workspace ID",
-      description: "Select a workspace to create the board in, or provide a workspace ID. If not specified, the **Main Workspace** will be used.",
+      description: "Select a workspace to create the board in, or provide a workspace ID. If not specified, the **Main Workspace** will be used",
       optional: true,
       async options() {
         return this.listWorkspacesOptions();
@@ -54,18 +54,18 @@ export default {
     templateId: {
       type: "integer",
       label: "Board Template ID",
-      description: "The board's template ID. You can obtain it from the URL when selecting the desired board (e.g. `https://{subdomain}.monday.com/boards/2419687965`) where `2419687965` is the template ID. [See the documentation](https://developer.monday.com/api-reference/reference/boards#create-a-board) for more information.",
+      description: "The board's template ID. You can obtain it from the URL when selecting the desired board (e.g. `https://{subdomain}.monday.com/boards/2419687965`) where `2419687965` is the template ID. [See the documentation](https://developer.monday.com/api-reference/reference/boards#create-a-board) for more information",
       optional: true,
     },
     groupName: {
       type: "string",
       label: "Group Name",
-      description: "The name of the new group.",
+      description: "The name of the new group",
     },
     groupId: {
       type: "string",
       label: "Group ID",
-      description: "Select a group or provide a group ID.",
+      description: "Select a group or provide a group ID",
       optional: true,
       async options({ boardId }) {
         return this.listGroupsOptions({
@@ -98,7 +98,7 @@ export default {
     itemId: {
       type: "string",
       label: "Item ID",
-      description: "Select an item or provide an item ID.",
+      description: "Select an item or provide an item ID",
       optional: true,
       async options({
         boardId, prevContext,
@@ -112,7 +112,7 @@ export default {
     updateId: {
       type: "string",
       label: "Update ID",
-      description: "Select an update or provide an update ID.",
+      description: "Select an update or provide an update ID",
       optional: true,
       async options({
         page, boardId,
@@ -126,7 +126,7 @@ export default {
     column: {
       type: "string",
       label: "Column",
-      description: "Select a column to watch for changes.",
+      description: "Select a column to watch for changes",
       async options({ boardId }) {
         const columns = await this.listColumnOptions({
           boardId: +boardId,
diff --git a/components/monday/sources/column-value-updated/column-value-updated.mjs b/components/monday/sources/column-value-updated/column-value-updated.mjs
@@ -19,7 +19,7 @@ export default {
     alertBox: {
       type: "alert",
       alertType: "warning",
-      content: "For changes to `Name`, use the **Name Updated** trigger.",
+      content: "For changes to `Name`, use the **Name Updated** trigger",
     },
   },
   methods: {
diff --git a/components/monday/sources/new-subitem-update/new-subitem-update.mjs b/components/monday/sources/new-subitem-update/new-subitem-update.mjs
@@ -13,7 +13,7 @@ export default {
     alertBox: {
       type: "alert",
       alertType: "warning",
-      content: "To create this trigger, you need to have at least one subitem previously created on your board.",
+      content: "To create this trigger, you need to have at least one subitem previously created on your board",
     },
     boardId: {
       propDefinition: [
@@ -25,7 +25,7 @@ export default {
   methods: {
     ...common.methods,
     getWebhookCreationError() {
-      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board.";
+      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board";
     },
     getWebhookArgs() {
       return {
diff --git a/components/monday/sources/new-subitem/new-subitem.mjs b/components/monday/sources/new-subitem/new-subitem.mjs
@@ -13,7 +13,7 @@ export default {
     alertBox: {
       type: "alert",
       alertType: "warning",
-      content: "To create this trigger, you need to have at least one subitem previously created on your board.",
+      content: "To create this trigger, you need to have at least one subitem previously created on your board",
     },
     boardId: {
       propDefinition: [
@@ -25,7 +25,7 @@ export default {
   methods: {
     ...common.methods,
     getWebhookCreationError() {
-      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board.";
+      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board";
     },
     getWebhookArgs() {
       return {
diff --git a/components/monday/sources/specific-column-updated/specific-column-updated.mjs b/components/monday/sources/specific-column-updated/specific-column-updated.mjs
@@ -19,7 +19,7 @@ export default {
     alertBox: {
       type: "alert",
       alertType: "warning",
-      content: "For changes to `Name`, use the **Name Updated** trigger.",
+      content: "For changes to `Name`, use the **Name Updated** trigger",
     },
     column: {
       propDefinition: [
diff --git a/components/monday/sources/subitem-column-value-updated/subitem-column-value-updated.mjs b/components/monday/sources/subitem-column-value-updated/subitem-column-value-updated.mjs
@@ -13,7 +13,7 @@ export default {
     alertBox: {
       type: "alert",
       alertType: "warning",
-      content: "To create this trigger, you need to have at least one subitem previously created on your board.",
+      content: "To create this trigger, you need to have at least one subitem previously created on your board",
     },
     boardId: {
       propDefinition: [
@@ -25,7 +25,7 @@ export default {
   methods: {
     ...common.methods,
     getWebhookCreationError() {
-      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board.";
+      return "Failed to establish webhook. To create this trigger, you need to have at least one subitem previously created on your board";
     },
     getWebhookArgs() {
       return {
diff --git a/components/monday/sources/subitem-name-updated/subitem-name-updated.mjs b/components/monday/sources/subitem-name-updated/subitem-name-updated.mjs

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ export default {`
`16`	`16`	`updateInfoBox: {`
`17`	`17`	`type: "alert",`
`18`	`18`	`alertType: "info",`
`19`		`- content: "See the [Column types reference](https://developer.monday.com/api-reference/reference/column-types-reference) to find the proper data structures for supported column types.",`
	`19`	`+ content: "See the [Column types reference](https://developer.monday.com/api-reference/reference/column-types-reference) to find the proper data structures for supported column types",`
`20`	`20`	`},`
`21`	`21`	`boardId: {`
`22`	`22`	`...common.props.boardId,`
`@@ -50,7 +50,7 @@ export default {`
`50`	`50`	`options: getColumnOptions(columns, id),`
`51`	`51`	`};`
`52`	`52`	`if (column.type === "file") {`
`53`		- props[column.id].description += ". The path to a file in the `/tmp` directory. [See the documentation on working with files](https://pipedream.com/docs/code/nodejs/working-with-files/#writing-a-file-to-tmp).";
	`53`	+ props[column.id].description += ". The path to a file in the `/tmp` directory. [See the documentation on working with files](https://pipedream.com/docs/code/nodejs/working-with-files/#writing-a-file-to-tmp)";
`54`	`54`	`}`
`55`	`55`	`}`
`56`	`56`	`}`