Convert if else statements to if() statements that return

Author: celestebancos

components/quickbooks/sources/common.js

@@ -112,11 +112,13 @@ module.exports = {
     const webhookCompanyId = event.body.eventNotifications[0].realmId;
     if (!this.isValidSource(event, webhookCompanyId)) {
       console.log("Skipping event from unrecognized source.");
-    } else {
-      await Promise.all(entities.map((entity) => {
-        entity.realmId = webhookCompanyId;
-        return this.validateAndEmit(entity);
-      }));
+      return;
+    } 
+
+    await Promise.all(entities.map((entity) => {
+      entity.realmId = webhookCompanyId;
+      return this.validateAndEmit(entity);
+    }));
     }
   },
 };

components/quickbooks/sources/custom-webhook-events/custom-webhook-events.js

@@ -31,12 +31,14 @@ module.exports = {
       // (it would a hassle for the user to select every option if they wanted to emit everything)
       if (this.namesToEmit.length > 0 && !this.namesToEmit.includes(entity.name)) {
         console.log(`Entity Type '${entity.name}' not found in list of selected Entity Types`);
-      } else if (this.operationsToEmit.length > 0
+        return;
+      }
+      if (this.operationsToEmit.length > 0
         && !this.operationsToEmit.includes(entity.operation)) {
         console.log(`Operation '${entity.operation}' not found in list of selected Operations`);
-      } else {
-        await this.processEvent(entity);
-      }
+        return;
+      } 
+      await this.processEvent(entity);
     },
   },
 };

components/quickbooks/sources/new-or-modified-customer/new-or-modified-customer.js

@@ -35,12 +35,14 @@ module.exports = {
       // if they wanted to emit everything)
       if (entity.name !== sourceEntity) {
         console.log(`${entity.name} webhook received and ignored, since it is not a Customer`);
-      } else if (this.operationsToEmit.length > 0
+        return;
+      } 
+      if (this.operationsToEmit.length > 0
         && !this.operationsToEmit.includes(entity.operation)) {
         console.log(`Operation '${entity.operation}' not found in list of selected Operations`);
-      } else {
-        await this.processEvent(entity);
+      return;
       }
+      await this.processEvent(entity);
     },
   },
 };