Remove checkPropsNeedConfiguring call

bzwrk · bzwrk · commit 34ca0dab8634 · 2025-01-24T17:14:14.000-06:00
diff --git a/packages/connect-react/src/hooks/form-context.tsx b/packages/connect-react/src/hooks/form-context.tsx
@@ -365,9 +365,6 @@ export const FormContextProvider = <T extends ConfigurableProps>({
       }
     }
     // propsNeedConfiguring.splice(0, propsNeedConfiguring.length, ..._propsNeedConfiguring)
-    // For some reason registerField is called in recursive loop if an empty
-    // propsNeedConfiguring is set to an empty _propsNeedConfiguring
-    if (!propsNeedConfiguring.length && !_propsNeedConfiguring.length) return
     setPropsNeedConfiguring(_propsNeedConfiguring)
   }
 
@@ -376,7 +373,6 @@ export const FormContextProvider = <T extends ConfigurableProps>({
       fields[field.prop.name] = field
       return fields
     });
-    checkPropsNeedConfiguring()
   };
 
   // console.log("***", configurableProps, configuredProps)

Original file line number	Diff line number	Diff line change
`@@ -365,9 +365,6 @@ export const FormContextProvider = <T extends ConfigurableProps>({`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`	`// propsNeedConfiguring.splice(0, propsNeedConfiguring.length, ..._propsNeedConfiguring)`
`368`		`- // For some reason registerField is called in recursive loop if an empty`
`369`		`- // propsNeedConfiguring is set to an empty _propsNeedConfiguring`
`370`		`- if (!propsNeedConfiguring.length && !_propsNeedConfiguring.length) return`
`371`	`368`	`setPropsNeedConfiguring(_propsNeedConfiguring)`
`372`	`369`	`}`
`373`	`370`
`@@ -376,7 +373,6 @@ export const FormContextProvider = <T extends ConfigurableProps>({`
`376`	`373`	`fields[field.prop.name] = field`
`377`	`374`	`return fields`
`378`	`375`	`});`
`379`		`- checkPropsNeedConfiguring()`
`380`	`376`	`};`
`381`	`377`
`382`	`378`	`// console.log("***", configurableProps, configuredProps)`