Always show labels on dynamic props

Author: bzwrk

packages/connect-react/src/components/ControlSelect.tsx

@@ -171,26 +171,16 @@ export function ControlSelect<T>({
     if (o) {
       if (Array.isArray(o)) {
         if (typeof o[0] === "object" && "value" in o[0]) {
-          const vs = [];
-          for (const _o of o) {
-            if (prop.withLabel) {
-              vs.push(_o);
-            } else {
-              vs.push(_o.value);
-            }
-          }
-          onChange(vs);
-        } else {
-          onChange(o);
-        }
-      } else if (typeof o === "object" && "value" in o) {
-        if (prop.withLabel) {
           onChange({
             __lv: o,
           });
         } else {
-          onChange(o.value);
+          onChange(o);
         }
+      } else if (typeof o === "object" && "value" in o) {
+        onChange({
+          __lv: o,
+        });
       } else {
         throw new Error("unhandled option type"); // TODO
       }

packages/connect-react/src/hooks/form-context.tsx

@@ -254,6 +254,12 @@ export const FormContextProvider = <T extends ConfigurableProps>({
     setErrors(_errors);
   };
 
+  useEffect(() => {
+    updateConfiguredPropsQueryDisabledIdx(_configuredProps)
+  }, [
+    _configuredProps,
+  ]);
+
   useEffect(() => {
     const newConfiguredProps: ConfiguredProps<T> = {};
     for (const prop of configurableProps) {

packages/connect-react/src/utils/component.ts

@@ -40,6 +40,9 @@ export function valuesFromOptions<T>(value: unknown | T[] | PropOptions<T>): T[]
     }
     return results
   }
+  if (value && typeof value === "object" &&  "__lv" in value && Array.isArray(value.__lv)) {
+    return value.__lv as T[]
+  }
   if (!Array.isArray(value))
     return []
   return value as T[]