(fix) GitHub Actions fixes from repo refactor: npm -> pnpm, Node 14 -> 18 for remaining GH actions (#14723)

Author: dylburger

.github/actions/git-diff-on-components/README.md

@@ -15,11 +15,13 @@ This action takes care of all components with dependencies that were modified bu
 ### `all_files`
 
 **Required** List of all files comming from `changed_files` step in `check_version` job github action workflow. It is necessary to set the action `Ana06/[email protected]` output in json format like
+
 ```
 ...
 with:
   format: json
 ```
+
 in that way `steps.changed_files.outputs.all` will be converted in array of strings
 
 ## Example usage
@@ -34,8 +36,10 @@ in that way `steps.changed_files.outputs.all` will be converted in array of stri
 ```
 
 ## Build
+
 You need to push all files generated in `dist` folder once you are finished with the build to test the new version of the github action in case you want to make modifications.
+
 ```
 $ cd .github/actions/git-diff-on-components/
-$ npm i && npm run build
-```
+$ pnpm i && pnpm run build
+```

.github/actions/git-diff-on-components/package.json

@@ -5,7 +5,7 @@
   "main": "dist/index.js",
   "scripts": {
     "clean": "rm -rf ./dist",
-    "build": "npm run clean && ncc build src/index.js --license licenses.txt"
+    "build": "pnpm run clean && ncc build src/index.js --license licenses.txt"
   },
   "keywords": [],
   "author": "pipedream",

.github/workflows/components-pr.yaml

@@ -73,7 +73,7 @@ jobs:
         run: pnpm install -r
       - name: Compile TypeScript
         id: compile
-        run: npm run build > files.txt
+        run: pnpm run build > files.txt
       - name: Get Changed Files
         id: files
         uses: Ana06/[email protected]
@@ -162,7 +162,7 @@ jobs:
         run: pnpm install -r
       - name: Compile TypeScript
         id: compile
-        run: npm run build > files.txt
+        run: pnpm run build > files.txt
       - name: Get Changed Files
         id: files
         uses: Ana06/[email protected]

.github/workflows/publish-components.yaml

@@ -31,11 +31,11 @@ jobs:
       - name: Setup Node Env
         uses: actions/[email protected]
         with:
-          node-version: 14
+          node-version: 18
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
       - name: Compile TypeScript
-        run: npm run build
+        run: pnpm run build
       - name: Install pd cli
         env:
           PD_API_KEY: ${{ secrets.PD_API_KEY }}
@@ -137,7 +137,7 @@ jobs:
       - name: Setup Node Env
         uses: actions/[email protected]
         with:
-          node-version: 14
+          node-version: 18
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
       - name: Install Dependencies
@@ -154,7 +154,7 @@ jobs:
           echo "org_id = $PD_ORG_ID" >> $HOME/.config/pipedream/config
       - name: Compile TypeScript
         id: compile
-        run: npm run build > files.txt
+        run: pnpm run build > files.txt
       - name: Get Changed Files
         id: files
         uses: Ana06/[email protected]

.github/workflows/publish-marketplace-content.yaml

@@ -31,7 +31,7 @@ jobs:
       - name: Setup Node Env
         uses: actions/[email protected]
         with:
-          node-version: 14
+          node-version: 18
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
       - name: Get Changed Files

.github/workflows/publish-packages.yaml

@@ -45,7 +45,7 @@ jobs:
       - name: pnpm install
         run: pnpm install -r --no-frozen-lockfile
       - name: Compile TypeScript
-        run: npm run build
+        run: pnpm run build
       # See https://pnpm.io/using-changesets
       - name: Setup npmrc for pnpm publish
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc

.github/workflows/publish-platform-package.yaml

@@ -24,7 +24,7 @@ jobs:
       - name: pnpm install
         run: pnpm install -r --no-frozen-lockfile
       - name: Compile TypeScript
-        run: npm run build
+        run: pnpm run build
       # See https://pnpm.io/using-changesets
       - name: Setup npmrc for pnpm publish
         run: echo "//registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }}" > .npmrc

.github/workflows/pull-request-checks.yaml

@@ -50,8 +50,14 @@ jobs:
       - name: Checkout Code
         uses: actions/[email protected]
         with:
-          # Full git history is needed to get a proper list of changed files
-          # within `super-linter`
+          # See https://github.com/actions/checkout#checkout-v2
+          # This will be slow. The intent is to fetch all commits
+          # since the merge-base (the commit where we branched off)
+          # so we can check the git diff against all changed files.
+          # By default, the checkout action only returns the last commit,
+          # There's no native way to do this in the checkout action, so
+          # we have to fetch the entire history. See
+          # https://github.com/actions/checkout/issues/266#issuecomment-638346893
           fetch-depth: 0
       - uses: pnpm/[email protected]
         with:
@@ -72,20 +78,10 @@ jobs:
       - name: Setup Node Env
         uses: actions/[email protected]
         with:
-          node-version: 18.18.0
+          node-version: 18
           registry-url: https://registry.npmjs.org/
           cache: 'pnpm'
-      # - name: Lint Code Base
-      #   uses: super-linter/super-linter/[email protected]
-      #   env:
-      #     DEFAULT_BRANCH: master
-      #     GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      #     JAVASCRIPT_ES_CONFIG_FILE: eslint.config.mjs
-      #     LINTER_RULES_PATH: /
-      #     VALIDATE_ALL_CODEBASE: false
-      #     VALIDATE_JAVASCRIPT_ES: true
-      #     VALIDATE_JSON: true
-      # ESLint only on changed files (not the same as the above super-linter)
+      # ESLint only on changed files
       - name: Get Changed Files (space-separated)
         id: changed_files_space
         uses: Ana06/[email protected]