Refactoring Microsoft Teams code to reliably check for external users and label them without Global Admin permissions.

Author: malexanderlim

components/microsoft_teams/microsoft_teams.app.mjs

@@ -58,76 +58,76 @@ export default {
     chat: {
       type: "string",
       label: "Chat",
-      description: "Team Chat (internal and external contacts)",
-      async options({ prevContext }) {
-        const response = prevContext.nextLink
+      description: "Select a chat (type to search by participant names)",
+      async options({ prevContext, searchTerm }) {
+        let path = "/chats?$expand=members";
+        path += "&$top=20";
+        
+        if (searchTerm) {
+          path += `&$search="${searchTerm}"`;
+        }
+        
+        const response = prevContext?.nextLink
           ? await this.makeRequest({
             path: prevContext.nextLink,
           })
-          : await this.listChats();
-
-        const myTenantId = await this.getAuthenticatedUserTenant();
-        const options = [];
-
+          : await this.makeRequest({
+            path,
+          });
+        
         this._userCache = this._userCache || new Map();
-
+        const options = [];
+        
         for (const chat of response.value) {
-          const messages = await this.makeRequest({
-            path: `/chats/${chat.id}/messages?$top=50`,
-          });
-
-          const members = await Promise.all(chat.members.map(async (member) => {
-            const cacheKey = `user_${member.userId}`;
-            let displayName = member.displayName || this._userCache.get(cacheKey);
-
-            if (!displayName) {
-              try {
-                if (messages?.value?.length > 0) {
-                  const userMessage = messages.value.find((msg) =>
-                    msg.from?.user?.id === member.userId);
-                  if (userMessage?.from?.user?.displayName) {
-                    displayName = userMessage.from.user.displayName;
-                  }
-                }
-
-                if (!displayName) {
-                  const userDetails = await this.makeRequest({
-                    path: `/users/${member.userId}`,
-                  });
-                  displayName = userDetails.displayName;
-                }
-
-                this._userCache.set(cacheKey, displayName);
-              } catch (err) {
-                if (err.statusCode === 404) {
-                  displayName = "User Not Found";
-                } else if (err.statusCode === 403) {
-                  displayName = "Access Denied";
-                } else {
-                  displayName = "Unknown User";
+          let members = chat.members.map(member => ({
+            displayName: member.displayName,
+            wasNull: !member.displayName,
+            userId: member.userId,
+            email: member.email
+          }));
+          
+          if (members.some(member => !member.displayName)) {
+            try {
+              const messages = await this.makeRequest({
+                path: `/chats/${chat.id}/messages?$top=10&$orderby=createdDateTime desc`,
+              });
+              
+              const nameMap = new Map();
+              messages.value.forEach(msg => {
+                if (msg.from?.user?.id && msg.from?.user?.displayName) {
+                  nameMap.set(msg.from.user.id, msg.from.user.displayName);
                 }
-                console.error(`Failed to fetch user details for ${member.userId}:`, err);
-              }
+              });
+              
+              members = members.map(member => ({
+                ...member,
+                displayName: member.displayName || nameMap.get(member.userId) || member.email || "Unknown User",
+              }));
+            } catch (err) {
+              console.error(`Failed to fetch messages for chat ${chat.id}:`, err);
             }
-
-            const isExternal = member.tenantId !== myTenantId || !member.tenantId;
-            return isExternal
-              ? `${displayName} (External)`
-              : displayName;
-          }));
-
+          }
+          
+          const memberNames = members.map(member => 
+            member.wasNull 
+              ? `${member.displayName} (External)`
+              : member.displayName
+          );
+          
           options.push({
-            label: members.join(", "),
+            label: memberNames.join(", "),
             value: chat.id,
           });
         }
+
         return {
           options,
           context: {
             nextLink: response["@odata.nextLink"],
           },
         };
       },
+      useQuery: true,
     },
     channelDisplayName: {
       type: "string",
@@ -192,22 +192,6 @@ export default {
             : reduction;
         }, api);
     },
-    async getAuthenticatedUserTenant() {
-      try {
-        const { value } = await this.client()
-          .api("/organization")
-          .get();
-
-        if (!value || value.length === 0) {
-          throw new Error("No organization found");
-        }
-
-        return value[0].id;
-      } catch (error) {
-        console.error("Failed to fetch tenant ID:", error);
-        throw new Error("Unable to determine tenant ID");
-      }
-    },
     async authenticatedUserId() {
       const { id } = await this.client()
         .api("/me")