Skip to content

Commit 5bcde2f

Browse files
committed
API method standardization
1 parent 55779a9 commit 5bcde2f

File tree

1 file changed

+43
-42
lines changed

1 file changed

+43
-42
lines changed

components/basecamp/basecamp.app.mjs

Lines changed: 43 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -319,50 +319,52 @@ export default {
319319
async getProjects(args = {}) {
320320
return this.makeRequest({
321321
path: "/projects.json",
322-
accountId: args.accountId,
323322
...args,
324323
});
325324
},
326-
async getPeople(args = {}) {
325+
async getPeople({
326+
projectId, ...args
327+
} = {}) {
327328
return this.makeRequest({
328-
path: `/projects/${args.projectId}/people.json`,
329-
accountId: args.accountId,
329+
path: `/projects/${projectId}/people.json`,
330330
...args,
331331
});
332332
},
333-
async getMessageTypes(args = {}) {
333+
async getMessageTypes({
334+
projectId, ...args
335+
} = {}) {
334336
return this.makeRequest({
335-
path: `/buckets/${args.projectId}/categories.json`,
336-
accountId: args.accountId,
337+
path: `/buckets/${projectId}/categories.json`,
337338
...args,
338339
});
339340
},
340-
async getProject(args = {}) {
341+
async getProject({
342+
projectId, ...args
343+
} = {}) {
341344
return this.makeRequest({
342-
path: `/projects/${args.projectId}.json`,
343-
accountId: args.accountId,
345+
path: `/projects/${projectId}.json`,
344346
...args,
345347
});
346348
},
347349
async getRecordings(args = {}) {
348350
return this.makeRequest({
349351
path: "/projects/recordings.json",
350-
accountId: args.accountId,
351352
...args,
352353
});
353354
},
354-
async getTodoLists(args = {}) {
355+
async getTodoLists({
356+
projectId, todoSetId, ...args
357+
} = {}) {
355358
return this.makeRequest({
356-
path: `/buckets/${args.projectId}/todosets/${args.todoSetId}/todolists.json`,
357-
accountId: args.accountId,
359+
path: `/buckets/${projectId}/todosets/${todoSetId}/todolists.json`,
358360
...args,
359361
});
360362
},
361-
async createMessage(args = {}) {
363+
async createMessage({
364+
projectId, messageBoardId, ...args
365+
} = {}) {
362366
return this.makeRequest({
363-
$: args.$,
364-
accountId: args.accountId,
365-
path: `/buckets/${args.projectId}/message_boards/${args.messageBoardId}/messages.json`,
367+
path: `/buckets/${projectId}/message_boards/${messageBoardId}/messages.json`,
366368
method: "post",
367369
...args,
368370
});
@@ -376,55 +378,56 @@ export default {
376378
...args,
377379
});
378380
},
379-
async createCampfireMessage(args = {}) {
381+
async createCampfireMessage({
382+
projectId, campfireId, ...args
383+
} = {}) {
380384
return this.makeRequest({
381-
$: args.$,
382-
accountId: args.accountId,
383-
path: `/buckets/${args.projectId}/chats/${args.campfireId}/lines.json`,
385+
path: `/buckets/${projectId}/chats/${campfireId}/lines.json`,
384386
method: "post",
385387
...args,
386388
});
387389
},
388-
async createComment(args = {}) {
390+
async createComment({
391+
projectId, recordingId, ...args
392+
} = {}) {
389393
return this.makeRequest({
390-
$: args.$,
391-
accountId: args.accountId,
392-
path: `/buckets/${args.projectId}/recordings/${args.recordingId}/comments.json`,
394+
path: `/buckets/${projectId}/recordings/${recordingId}/comments.json`,
393395
method: "post",
394396
...args,
395397
});
396398
},
397-
async createTodoItem(args = {}) {
399+
async createTodoItem({
400+
projectId, todoListId, ...args
401+
} = {}) {
398402
return this.makeRequest({
399-
$: args.$,
400-
accountId: args.accountId,
401-
path: `/buckets/${args.projectId}/todolists/${args.todoListId}/todos.json`,
403+
path: `/buckets/${projectId}/todolists/${todoListId}/todos.json`,
402404
method: "post",
403405
...args,
404406
});
405407
},
406-
async createWebhook(args = {}) {
408+
async createWebhook({
409+
projectId, ...args
410+
} = {}) {
407411
return this.makeRequest({
408-
path: `/buckets/${args.projectId}/webhooks.json`,
409-
accountId: args.accountId,
412+
path: `/buckets/${projectId}/webhooks.json`,
410413
method: "post",
411414
...args,
412415
});
413416
},
414-
async deleteWebhook(args = {}) {
417+
async deleteWebhook({
418+
projectId, webhookId, ...args
419+
} = {}) {
415420
return this.makeRequest({
416-
path: `/buckets/${args.projectId}/webhooks/${args.webhookId}.json`,
417-
accountId: args.accountId,
421+
path: `/buckets/${projectId}/webhooks/${webhookId}.json`,
418422
method: "delete",
419423
...args,
420424
});
421425
},
422426
getCardTable({
423-
accountId, projectId, cardTableId, ...args
427+
projectId, cardTableId, ...args
424428
}) {
425429
return this.makeRequest({
426430
path: `/buckets/${projectId}/card_tables/${cardTableId}.json`,
427-
accountId,
428431
...args,
429432
});
430433
},
@@ -449,20 +452,18 @@ export default {
449452
return lists;
450453
},
451454
getChatbot({
452-
accountId, projectId, campfireId, botId, ...args
455+
projectId, campfireId, botId, ...args
453456
}) {
454457
return this.makeRequest({
455458
path: `/buckets/${projectId}/chats/${campfireId}/integrations/${botId}.json`,
456-
accountId,
457459
...args,
458460
});
459461
},
460462
listChatbots({
461-
accountId, projectId, campfireId, ...args
463+
projectId, campfireId, ...args
462464
}) {
463465
return this.makeRequest({
464466
path: `/buckets/${projectId}/chats/${campfireId}/integrations.json`,
465-
accountId,
466467
...args,
467468
});
468469
},

0 commit comments

Comments
 (0)