Skip to content

Commit 9bcacc3

Browse files
committed
addressed coderabbit review feedback
1 parent e4a1037 commit 9bcacc3

File tree

3 files changed

+25
-6
lines changed

3 files changed

+25
-6
lines changed

components/databricks/actions/create-vector-search-index/create-vector-search-index.mjs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,18 @@ export default {
9898
: utils.parseObject(this.columnsToSync);
9999

100100
const embeddingSourceColumns = Array.isArray(this.embeddingSourceColumns)
101-
? this.embeddingSourceColumns.map((item) =>
102-
typeof item === "string"
103-
? JSON.parse(item)
104-
: item)
101+
? this.embeddingSourceColumns.map((item, idx) => {
102+
if (typeof item === "string") {
103+
try {
104+
return JSON.parse(item);
105+
} catch (e) {
106+
throw new ConfigurationError(
107+
`embeddingSourceColumns[${idx}] is not valid JSON: ${e.message}`,
108+
);
109+
}
110+
}
111+
return item;
112+
})
105113
: utils.parseObject(this.embeddingSourceColumns);
106114

107115
if (!Array.isArray(columnsToSync) || !columnsToSync.length) {

components/databricks/actions/list-vector-search-indexes/list-vector-search-indexes.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default {
2323
do {
2424
const {
2525
vector_indexes, next_page_token,
26-
} = await this.databricks.listIndexes({
26+
} = await this.databricks.listVectorSearchIndexes({
2727
params: {
2828
endpoint_name: this.endpointName,
2929
...(pageToken

components/databricks/actions/query-vector-search-index/query-vector-search-index.mjs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,24 @@ export default {
6464
if (this.queryVector) {
6565
try {
6666
payload.query_vector = JSON.parse(this.queryVector);
67+
if (
68+
!Array.isArray(payload.query_vector) ||
69+
payload.query_vector.length === 0 ||
70+
!payload.query_vector.every((n) => typeof n === "number" && Number.isFinite(n))
71+
) {
72+
throw new Error("`queryVector` must be a non-empty JSON array of finite numbers.");
73+
}
6774
} catch (err) {
6875
throw new Error(`Invalid queryVector JSON: ${err.message}`);
6976
}
7077
}
7178

7279
if (this.filtersJson) {
73-
payload.filters_json = utils.parseObject(this.filtersJson);
80+
try {
81+
payload.filters_json = utils.parseObject(this.filtersJson);
82+
} catch (err) {
83+
throw new Error(`Invalid filtersJson: ${err.message}`);
84+
}
7485
}
7586

7687
if (this.includeEmbeddings !== undefined) {

0 commit comments

Comments
 (0)