Skip to content

Commit 9ea188a

Browse files
committed
addressed coderabbit review feedback
1 parent 13a1c59 commit 9ea188a

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

components/databricks/actions/create-vector-search-index/create-vector-search-index.mjs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,14 @@ export default {
5555
type: "string[]",
5656
label: "Embedding Source Columns",
5757
description:
58-
"List of embedding source column configs. Each entry should be a JSON object string like `[ { \"embedding_model_endpoint_name\": \"e5-small-v2\", \"name\": \"text\" } ]` (required for `DELTA_SYNC`).",
58+
"List of embedding source column configs. Each entry is a JSON object string like `{ \"embedding_model_endpoint_name\": \"e5-small-v2\", \"name\": \"text\" }`. Provide when Databricks computes embeddings (DELTA_SYNC).",
59+
optional: true,
60+
},
61+
embeddingVectorColumns: {
62+
type: "string[]",
63+
label: "Embedding Vector Columns",
64+
description:
65+
"List of self-managed vector column configs. Each entry is a JSON object string like `{ \"name\": \"text_vector\", \"embedding_dimension\": 1536 }`. Provide when you manage embeddings yourself (DELTA_SYNC).",
5966
optional: true,
6067
},
6168
schemaJson: {
@@ -137,6 +144,11 @@ export default {
137144
"Provide either embeddingSourceColumns (compute embeddings) or embeddingVectorColumns (self-managed) for DELTA_SYNC indexes.",
138145
);
139146
}
147+
if (hasSource && hasVectors) {
148+
throw new ConfigurationError(
149+
"Provide only one of embeddingSourceColumns or embeddingVectorColumns for DELTA_SYNC indexes.",
150+
);
151+
}
140152

141153
const deltaSpec = {
142154
source_table: this.sourceTable,

0 commit comments

Comments
 (0)