create-purchase-order updates

Author: michelle0927

components/quickbooks/actions/create-purchase-order/create-purchase-order.mjs

@@ -14,13 +14,22 @@ export default {
   props: {
     quickbooks,
     accountId: {
-      propDefinition: [
-        quickbooks,
-        "accountIds",
-      ],
       type: "string",
       label: "Account ID",
       description: "The ID of the account to use for the purchase order",
+      async options() {
+        const { QueryResponse: queryResponse } = await this.quickbooks.query({
+          params: {
+            query: "select * from Account where Classification = 'Liability' AND AccountSubType = 'AccountsPayable'",
+          },
+        });
+        return queryResponse.Account.map(({
+          Id, Name,
+        }) => ({
+          value: Id,
+          label: Name,
+        }));
+      },
     },
     vendorRefValue: {
       propDefinition: [
@@ -102,7 +111,7 @@ export default {
       props.lineItems = {
         type: "string[]",
         label: "Line Items",
-        description: "Line items of a purchase order. Set DetailType to `ItemBasedExpenseLineDetail` or `AccountBasedExpenseLineDetail`. Example: `{ \"DetailType\": \"ItemBasedExpenseLineDetail\", \"Amount\": 100.0, \"ItemBasedExpenseLineDetail\": { \"ItemRef\": { \"name\": \"Services\", \"value\": \"1\" } } }` [See the documentation](https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/purchaseorder#create-a-purchaseorder) for more information.",
+        description: "Line items of a purchase order. DetailType is `ItemBasedExpenseLineDetail`. Example: `{ \"DetailType\": \"ItemBasedExpenseLineDetail\", \"Amount\": 100.0, \"ItemBasedExpenseLineDetail\": { \"ItemRef\": { \"name\": \"Services\", \"value\": \"1\" } } }` [See the documentation](https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/purchaseorder#create-a-purchaseorder) for more information.",
       };
       return props;
     }
@@ -116,35 +125,26 @@ export default {
       return props;
     }
     for (let i = 1; i <= this.numLineItems; i++) {
-      props[`detailType_${i}`] = {
-        type: "string",
-        label: `Line ${i} - Detail Type`,
-        options: [
-          {
-            label: "Item Based Expense",
-            value: "ItemBasedExpenseLineDetail",
-          },
-          {
-            label: "Account Based Expense",
-            value: "AccountBasedExpenseLineDetail",
-          },
-        ],
-        default: "ItemBasedExpenseLineDetail",
-      };
       props[`item_${i}`] = {
         type: "string",
         label: `Line ${i} - Item/Account ID`,
         options: async ({ page }) => {
-          return this.quickbooks.getPropOptions({
+          const options = await this.quickbooks.getPropOptions({
             page,
             resource: "Item",
             mapper: ({
-              Id: value, Name: label,
-            }) => ({
-              value,
-              label,
-            }),
+              Id: value, Name: label, ExpenseAccountRef,
+            }) => {
+              if (ExpenseAccountRef) {
+                return {
+                  value,
+                  label,
+                };
+              }
+              return null;
+            },
           });
+          return options.filter((option) => option !== null);
         },
       };
       props[`amount_${i}`] = {
@@ -180,12 +180,6 @@ export default {
       throw new ConfigurationError("No valid line items were provided.");
     }
 
-    lines.forEach((line, index) => {
-      if (line.DetailType !== "ItemBasedExpenseLineDetail" && line.DetailType !== "AccountBasedExpenseLineDetail") {
-        throw new ConfigurationError(`Line Item at index ${index + 1} has invalid DetailType '${line.DetailType}'. Must be 'ItemBasedExpenseLineDetail' or 'AccountBasedExpenseLineDetail'`);
-      }
-    });
-
     const hasShippingAddress = this.shippingStreetAddress
       || this.shippingCity
       || this.shippingState

components/quickbooks/common/utils.mjs

@@ -171,26 +171,9 @@ export function buildPurchaseLineItems(numLineItems, context) {
     throw new ConfigurationError(`Invalid amount values for: ${invalidAmounts.join(", ")}. Amounts must be valid numbers.`);
   }
 
-  // Validate detailType values if provided
-  const validDetailTypes = [
-    "ItemBasedExpenseLineDetail",
-    "AccountBasedExpenseLineDetail",
-  ];
-  const invalidDetailTypes = [];
-  for (let i = 1; i <= numLineItems; i++) {
-    const detailType = context[`detailType_${i}`];
-    if (detailType && !validDetailTypes.includes(detailType)) {
-      invalidDetailTypes.push(`detailType_${i}: ${detailType}`);
-    }
-  }
-
-  if (invalidDetailTypes.length > 0) {
-    throw new ConfigurationError(`Invalid detailType values for: ${invalidDetailTypes.join(", ")}. Valid types are: ${validDetailTypes.join(", ")}`);
-  }
-
   const lineItems = [];
   for (let i = 1; i <= numLineItems; i++) {
-    const detailType = context[`detailType_${i}`] || "ItemBasedExpenseLineDetail";
+    const detailType = "ItemBasedExpenseLineDetail";
 
     // Extract conditional logic into clear variables
     const isItemBased = detailType === "ItemBasedExpenseLineDetail";

components/quickbooks/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pipedream/quickbooks",
-  "version": "0.6.0",
+  "version": "0.6.1",
   "description": "Pipedream Quickbooks Components",
   "main": "quickbooks.app.mjs",
   "keywords": [