PR feedback

Author: dannyroosevelt

packages/connect-react/src/hooks/form-context.tsx

@@ -86,19 +86,19 @@ export const FormContextProvider = <T extends ConfigurableProps>({
   // Resolve user ID with deprecation warning
   const {
     resolvedId: resolvedExternalUserId, warningType,
-  } = useMemo(() =>
-    resolveUserId(externalUserId, userId),
-  [
+  } = useMemo(() => resolveUserId(externalUserId, userId), [
     externalUserId,
     userId,
   ]);
 
   // Show deprecation warnings in useEffect to avoid render side effects
   useEffect(() => {
-    if (warningType === "both") {
-      console.warn("[connect-react] Both externalUserId and userId provided. Using externalUserId. Please remove userId to avoid this warning.");
-    } else if (warningType === "deprecated") {
-      console.warn("[connect-react] userId is deprecated. Please use externalUserId instead.");
+    if (process.env.NODE_ENV !== "production") {
+      if (warningType === "both") {
+        console.warn("[connect-react] Both externalUserId and userId provided. Using externalUserId. Please remove userId to avoid this warning.");
+      } else if (warningType === "deprecated") {
+        console.warn("[connect-react] userId is deprecated. Please use externalUserId instead.");
+      }
     }
   }, [
     warningType,

packages/connect-react/src/utils/resolve-user-id.ts

@@ -6,8 +6,8 @@ export const resolveUserId = (
   externalUserId?: string,
   userId?: string,
 ): { resolvedId: string; warningType?: "both" | "deprecated" } => {
-  if (externalUserId) {
-    if (userId) {
+  if (externalUserId !== undefined && externalUserId !== "") {
+    if (userId !== undefined && userId !== "") {
       return {
         resolvedId: externalUserId,
         warningType: "both",
@@ -18,7 +18,7 @@ export const resolveUserId = (
     };
   }
 
-  if (userId) {
+  if (userId !== undefined && userId !== "") {
     return {
       resolvedId: userId,
       warningType: "deprecated",