Check if a string prop is set instead of inspecting the contents of the string

Author: bzwrk

packages/connect-react/CHANGELOG.md

@@ -1,6 +1,10 @@
 <!-- markdownlint-disable MD024 -->
 # Changelog
 
+# [1.0.0-preview.20] - 2025-01-16
+
+- Check if a string prop is set instead of inspecting the contents of the string
+
 # [1.0.0-preview.15] - 2024-12-18
 
 - Emit dynamic props via `onUpdateDynamicProps`

packages/connect-react/src/utils/component.ts

@@ -94,15 +94,13 @@ export function integerPropErrors(opts: ValidationOpts<ConfigurablePropInteger>)
 }
 
 export function stringPropErrors(opts: ValidationOpts<ConfigurablePropString>): string[] | undefined {
-  const _value = valueFromOption(opts.value)
+  const {
+    prop, value: valueOpt,
+  } = opts
 
-  if (!opts.prop.default) {
-    if (typeof _value === "undefined" || _value == null) {
-      return [
-        "required",
-      ]
-    }
-  }
+  if (!prop.default && (valueOpt == null || typeof value === "undefined")) return [
+    "required",
+  ]
 }
 
 type AppWithExtractedCustomFields = App & {