addressed coderabbit review feedback

Author: Lokeshchand33

components/databricks/actions/create-vector-search-index/create-vector-search-index.mjs

@@ -26,7 +26,10 @@ export default {
       type: "string",
       label: "Index Type",
       description: "Type of index (`DELTA_SYNC` or `DIRECT_ACCESS`).",
-      options: ["DELTA_SYNC", "DIRECT_ACCESS"],
+      options: [
+        "DELTA_SYNC",
+        "DIRECT_ACCESS",
+      ],
     },
     primaryKey: {
       type: "string",
@@ -58,7 +61,10 @@ export default {
       type: "string",
       label: "Pipeline Type",
       description: "Pipeline type for syncing (default: TRIGGERED).",
-      options: ["TRIGGERED", "CONTINUOUS"],
+      options: [
+        "TRIGGERED",
+        "CONTINUOUS",
+      ],
       optional: true,
       default: "TRIGGERED",
     },
@@ -75,26 +81,31 @@ export default {
     if (this.indexType === "DELTA_SYNC") {
       if (!this.sourceTable) {
         throw new ConfigurationError(
-          "sourceTable is required when indexType is DELTA_SYNC."
+          "sourceTable is required when indexType is DELTA_SYNC.",
         );
       }
+      const columnsToSync = Array.isArray(this.columnsToSync)
+        ? this.columnsToSync
+        : utils.parseObject(this.columnsToSync);
 
-      const columnsToSync = utils.parseObject(this.columnsToSync);
-      const embeddingSourceColumns = utils.parseObject(
-        this.embeddingSourceColumns
-      );
+      const embeddingSourceColumns = Array.isArray(this.embeddingSourceColumns)
+        ? this.embeddingSourceColumns.map((item) =>
+          typeof item === "string"
+            ? JSON.parse(item)
+            : item)
+        : utils.parseObject(this.embeddingSourceColumns);
 
       if (!Array.isArray(columnsToSync) || !columnsToSync.length) {
         throw new ConfigurationError(
-          "columnsToSync must be a non-empty array for DELTA_SYNC indexes."
+          "columnsToSync must be a non-empty array for DELTA_SYNC indexes.",
         );
       }
       if (
         !Array.isArray(embeddingSourceColumns) ||
         !embeddingSourceColumns.length
       ) {
         throw new ConfigurationError(
-          "embeddingSourceColumns must be a non-empty array for DELTA_SYNC indexes."
+          "embeddingSourceColumns must be a non-empty array for DELTA_SYNC indexes.",
         );
       }
 
@@ -113,7 +124,7 @@ export default {
 
     $.export(
       "$summary",
-      `Successfully created vector search index: ${response?.name || this.name}`
+      `Successfully created vector search index: ${response?.name || this.name}`,
     );
     return response;
   },

components/databricks/actions/delete-vector-search-index-data/delete-vector-search-index-data.mjs

@@ -30,10 +30,12 @@ export default {
     if (!keys.length) {
       throw new Error("Please provide at least one primary key to delete.");
     }
-    
+
     const response = await this.databricks.deleteVectorSearchData({
       indexName: this.indexName,
-      params: { primary_keys: keys }, 
+      data: {
+        primary_keys: keys,
+      },
       $,
     });
 

components/databricks/actions/get-vector-search-index/get-vector-search-index.mjs

@@ -11,7 +11,7 @@ export default {
     indexName: {
       propDefinition: [
         databricks,
-        "indexName", 
+        "indexName",
       ],
     },
   },

components/databricks/actions/list-vector-search-indexes/list-vector-search-indexes.mjs

@@ -11,10 +11,14 @@ export default {
   },
 
   async run({ $ }) {
-    const response = await this.databricks.listVectorSearchIndexes({ $ });
+    const response = await this.databricks.listVectorSearchIndexes({
+      $,
+    });
 
     const count = response?.vector_indexes?.length || 0;
-    $.export("$summary", `Found ${count} vector search index${count === 1 ? "" : "es"}`);
+    $.export("$summary", `Found ${count} vector search index${count === 1
+      ? ""
+      : "es"}`);
 
     return response;
   },

components/databricks/actions/upsert-vector-search-index-data/upsert-vector-search-index-data.mjs

@@ -13,7 +13,7 @@ export default {
     indexName: {
       propDefinition: [
         databricks,
-        "indexName",  
+        "indexName",
       ],
     },
     rows: {

components/databricks/databricks.app.mjs

@@ -59,17 +59,15 @@ export default {
         })) || [];
       },
     },
-    indexName: {  
+    indexName: {
       type: "string",
       label: "Vector Search Index",
       description: "The name of the vector search index",
       async options() {
         const { vector_indexes } = await this.listVectorSearchIndexes();
-        return vector_indexes?.map(({
-          name: value,
-        }) => ({
+        return vector_indexes?.map(({ name: value }) => ({
           value,
-          label: value, 
+          label: value,
         })) || [];
       },
     },
@@ -221,7 +219,9 @@ export default {
       });
     },
 
-    getVectorSearchIndex({ indexName, ...args }) {
+    getVectorSearchIndex({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}`,
         method: "GET",
@@ -237,47 +237,59 @@ export default {
       });
     },
 
-    deleteVectorSearchIndex({ indexName, ...args }) {
+    deleteVectorSearchIndex({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}`,
         method: "DELETE",
         ...args,
       });
     },
 
-    queryVectorSearchIndex({ indexName, ...args }) {
+    queryVectorSearchIndex({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}/query`,
         method: "POST",
         ...args,
       });
     },
 
-    syncVectorSearchIndex({ indexName, ...args }) {
+    syncVectorSearchIndex({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}/sync`,
         method: "POST",
         ...args,
       });
     },
 
-    deleteVectorSearchData({ indexName,...args }) {
+    deleteVectorSearchData({
+      indexName, ...args
+    }) {
       return this._makeRequest({
+        path: `/vector-search/indexes/${indexName}/delete-data`,
         method: "DELETE",
-        url: `/api/2.0/vector-search/indexes/${indexName}/delete-data`,
-        ...args, 
+        ...args,
       });
     },
 
-    upsertVectorSearchIndexData({ indexName, ...args }) {
+    upsertVectorSearchIndexData({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}/upsert-data`,
         method: "POST",
         ...args,
       });
     },
 
-    scanVectorSearchIndex({ indexName, ...args }) {
+    scanVectorSearchIndex({
+      indexName, ...args
+    }) {
       return this._makeRequest({
         path: `/vector-search/indexes/${indexName}/scan`,
         method: "POST",