Improvements

Author: GTFalcao

components/sage_accounting/actions/create-contact-payment/create-contact-payment.mjs

@@ -1,4 +1,5 @@
 import app from "../../sage_accounting.app.mjs";
+import { optionalParseFloat } from "../../common/utils.mjs";
 
 export default {
   key: "sage_accounting-create-contact-payment",
@@ -113,28 +114,14 @@ export default {
       date: this.date,
       total_amount: parseFloat(this.totalAmount),
       payment_method_id: this.paymentMethodId,
-      net_amount: this.netAmount
-        ? parseFloat(this.netAmount)
-        : undefined,
-      tax_amount: this.taxAmount
-        ? parseFloat(this.taxAmount)
-        : undefined,
+      net_amount: optionalParseFloat(this.netAmount),
+      tax_amount: optionalParseFloat(this.taxAmount),
       currency_id: this.currencyId,
-      exchange_rate: this.exchangeRate
-        ? parseFloat(this.exchangeRate)
-        : undefined,
-      base_currency_net_amount: this.baseCurrencyNetAmount
-        ? parseFloat(this.baseCurrencyNetAmount)
-        : undefined,
-      base_currency_tax_amount: this.baseCurrencyTaxAmount
-        ? parseFloat(this.baseCurrencyTaxAmount)
-        : undefined,
-      base_currency_total_amount: this.baseCurrencyTotalAmount
-        ? parseFloat(this.baseCurrencyTotalAmount)
-        : undefined,
-      base_currency_currency_charge: this.baseCurrencyCurrencyCharge
-        ? parseFloat(this.baseCurrencyCurrencyCharge)
-        : undefined,
+      exchange_rate: optionalParseFloat(this.exchangeRate),
+      base_currency_net_amount: optionalParseFloat(this.baseCurrencyNetAmount),
+      base_currency_tax_amount: optionalParseFloat(this.baseCurrencyTaxAmount),
+      base_currency_total_amount: optionalParseFloat(this.baseCurrencyTotalAmount),
+      base_currency_currency_charge: optionalParseFloat(this.baseCurrencyCurrencyCharge),
       reference: this.paymentReference,
       tax_rate_id: this.taxRateId,
     };
@@ -144,7 +131,7 @@ export default {
       data,
     });
 
-    $.export("$summary", `Successfully created contact payment with ID: ${response.id}`);
+    $.export("$summary", `Successfully created contact payment (ID: ${response.id})`);
     return response;
   },
 };

components/sage_accounting/actions/create-contact/create-contact.mjs

@@ -1,4 +1,3 @@
-import { ConfigurationError } from "@pipedream/platform";
 import app from "../../sage_accounting.app.mjs";
 
 export default {
@@ -141,13 +140,6 @@ export default {
     },
   },
   async run({ $ }) {
-    if (!this.name) {
-      throw new ConfigurationError("Name is required");
-    }
-    if (!this.contactTypeIds || this.contactTypeIds.length === 0) {
-      throw new ConfigurationError("At least one Contact Type ID is required");
-    }
-
     const response = await this.app.createContact({
       $,
       data: {

components/sage_accounting/actions/update-contact/update-contact.mjs

@@ -1,4 +1,3 @@
-import { ConfigurationError } from "@pipedream/platform";
 import app from "../../sage_accounting.app.mjs";
 
 export default {
@@ -149,10 +148,6 @@ export default {
     },
   },
   async run({ $ }) {
-    if (!this.contactId) {
-      throw new ConfigurationError("Contact ID is required");
-    }
-
     const response = await this.app.updateContact({
       $,
       contactId: this.contactId,

components/sage_accounting/common/utils.mjs

@@ -0,0 +1,5 @@
+export function optionalParseFloat(value) {
+  return typeof value === "string"
+    ? parseFloat(value)
+    : value;
+}