[Usability Audit] Stripe

Author: jcortes

components/stripe/actions/cancel-payment-intent/cancel-payment-intent.mjs

@@ -1,4 +1,3 @@
-import pick from "lodash.pick";
 import app from "../../stripe.app.mjs";
 
 export default {
@@ -16,22 +15,27 @@ export default {
     id: {
       propDefinition: [
         app,
-        "payment_intent",
+        "paymentIntent",
       ],
       optional: false,
     },
-    cancellation_reason: {
+    cancellationReason: {
       propDefinition: [
         app,
-        "payment_intent_cancellation_reason",
+        "paymentIntentCancellationReason",
       ],
     },
   },
   async run({ $ }) {
-    const params = pick(this, [
-      "cancellation_reason",
-    ]);
-    const resp = await this.app.sdk().paymentIntents.cancel(this.id, params);
+    const {
+      app,
+      id,
+      cancellationReason,
+    } = this;
+
+    const resp = await app.sdk().paymentIntents.cancel(id, {
+      cancellation_reason: cancellationReason,
+    });
     $.export("$summary", "Successfully cancelled payment intent");
     return resp;
   },

components/stripe/actions/capture-payment-intent/capture-payment-intent.mjs

@@ -1,6 +1,4 @@
-import pick from "lodash.pick";
 import app from "../../stripe.app.mjs";
-import utils from "../../common/utils.mjs";
 
 export default {
   key: "stripe-capture-payment-intent",
@@ -14,39 +12,81 @@ export default {
     id: {
       propDefinition: [
         app,
-        "payment_intent",
+        "paymentIntent",
       ],
       optional: false,
     },
-    amount_to_capture: {
+    amountToCapture: {
+      description: "The amount to capture from the PaymentIntent, which must be less than or equal to the original amount. Defaults to the full `amount_capturable` if it's not provided.",
       propDefinition: [
         app,
         "amount",
       ],
-      description: "The amount to capture, which must be less than or equal to the original " +
-        "amount. Any additional amount will be automatically refunded. Defaults to the full " +
-        "`amount_capturable` if not provided.",
     },
-    advanced: {
+    metadata: {
       propDefinition: [
         app,
         "metadata",
       ],
-      label: "Advanced Options",
-      description: "Specify less-common options that you require. See [Capture a PaymentIntent]" +
-        "(https://stripe.com/docs/api/payment_intents/capture) for a list of supported options.",
+    },
+    applicationFeeAmount: {
+      type: "integer",
+      label: "Application Fee Amount",
+      description: "The amount of the application fee (if any) that will be requested to be applied to the payment and transferred to the application owner’s Stripe account. The amount of the application fee collected will be capped at the total amount captured. For more information, see the PaymentIntents use case for connected accounts.",
+      optional: true,
+    },
+    finalCapture: {
+      type: "boolean",
+      label: "Final Capture",
+      description: "When capturing a PaymentIntent, setting final_capture to false notifies Stripe to not release the remaining uncaptured funds to make sure that they're captured in future requests. You can only use this setting when multicapture is available for PaymentIntents.",
+      optional: true,
+    },
+    statementDescriptor: {
+      propDefinition: [
+        app,
+        "statementDescriptor",
+      ],
+    },
+    statementDescriptorSuffix: {
+      type: "string",
+      label: "Statement Descriptor Suffix",
+      description: "Provides information about a card charge. Concatenated to the account’s statement descriptor prefix to form the complete statement descriptor that appears on the customer’s statement.",
+      optional: true,
+    },
+    transferDataAmount: {
+      type: "integer",
+      label: "Transfer Data Amount",
+      description: "The amount that will be transferred automatically when a charge succeeds.",
+      optional: true,
     },
   },
   async run({ $ }) {
-    const params = pick(this, [
-      "amount_to_capture",
-    ]);
-    const resp = await this.app.sdk().paymentIntents.capture(this.id, {
-      ...params,
-      ...utils.parseJson(this.advanced),
+    const {
+      id,
+      amountToCapture,
+      metadata,
+      applicationFeeAmount,
+      finalCapture,
+      statementDescriptor,
+      statementDescriptorSuffix,
+      transferDataAmount,
+    } = this;
+
+    const resp = await this.app.sdk().paymentIntents.capture(id, {
+      amount_to_capture: amountToCapture,
+      metadata,
+      application_fee_amount: applicationFeeAmount,
+      final_capture: finalCapture,
+      statement_descriptor: statementDescriptor,
+      statement_descriptor_suffix: statementDescriptorSuffix,
+      ...(transferDataAmount && {
+        transfer_data: {
+          amount: transferDataAmount,
+        },
+      }),
     });
-    $.export("$summary", `Successfully captured ${params.amount_to_capture
-      ? params.amount_to_capture
+    $.export("$summary", `Successfully captured ${amountToCapture
+      ? amountToCapture
       : `the full ${resp.amount_capturable}`} from the payment intent`);
     return resp;
   },