Skip to content

[BUG] New HubSpot triggers not firing on set up (ex: new-deal-in-stage) #18416

@iiradia

Description

@iiradia

Describe the bug
I believe this change c4316f7#diff-f5885b2af62ed1ea7ecfb2c8b93d3d92f109774a0e52384df49b9feed45ec34eR17

caused an issue with setting up new HubSpot triggers in Pipedream where the after timestamp is now initially set to undefined. For example, in the body of isRelevant() methods inside HubSpot new-deal-in-stage triggers (and most others), the logic

isRelevant(ts, updatedAfter) {
      return ts > updatedAfter;
    }

is used, however this always returns false when updatedAfter is undefined.

To Reproduce
Steps to reproduce the behavior:

  1. Go to New Source on Pipedream
  2. Click on 'HubSpot' -> 'New Deal In Stage'
  3. Configure Pipeline / Stage / Name for the trigger
  4. Click 'Create Source'
  5. Move a deal to the target stage on HubSpot UI
  6. Press Run Now once the source is createdExpected behavior
    The

Expected Behavior
You should see the source create an event on the page for that source, but this is not seen for new sources now since isRelevant returns false.

Screenshots
I created a new HubSpot source and added some debug logs, where the previous behavior returns 'true' on the first try for the isRelevant call, but the new behavior consistently returns false since after_prev is undefined.

Image Image

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtriagedFor maintainers: This issue has been triaged by a Pipedream employee

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions