Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Oct 22, 2024

Resolves #14346

The API version for the LinkedIn app was previously updated, but the LinkedIn Ads components were not republished with this update. Bumping their versions to republish with updated API version.

Summary by CodeRabbit

Release Notes

  • New Features

    • Added new properties for enhanced functionality in LinkedIn Ads: adAccountId, campaignId, accounts, eventId, conversionId, and leadFormId.
  • Version Updates

    • Incremented version numbers for multiple components to reflect new iterations:
      • create-report-by-advertiser-account: 0.0.3 → 0.0.4
      • create-report-by-campaign: 0.0.3 → 0.0.4
      • create-report: 0.0.3 → 0.0.4
      • send-conversion-event: 0.0.2 → 0.0.3
      • new-event-registration-form-response: 0.0.2 → 0.0.3
      • new-lead-gen-form-created: 0.0.1 → 0.0.2
      • package.json: 0.3.0 → 0.3.1
  • Improvements

    • Refined API request structure by removing unnecessary debug parameters for cleaner requests.

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Oct 22, 2024 3:42pm
pipedream-docs ⬜️ Ignored (Inspect) Oct 22, 2024 3:42pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Oct 22, 2024 3:42pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2024

Walkthrough

The pull request includes updates to multiple files within the LinkedIn Ads component, primarily focusing on incrementing version numbers for various modules. The changes affect the create-report-by-advertiser-account, create-report-by-campaign, create-report, send-conversion-event, and several source files, with version updates reflecting minor revisions. Additionally, the linkedin_ads.app.mjs file has been enhanced with new property definitions and refined API request structures, while package.json has been updated to reflect a new dependency and version.

Changes

File Change Summary
components/linkedin_ads/actions/create-report-by-advertiser-account/create-report-by-advertiser-account.mjs Version updated from "0.0.3" to "0.0.4".
components/linkedin_ads/actions/create-report-by-campaign/create-report-by-campaign.mjs Version updated from "0.0.3" to "0.0.4".
components/linkedin_ads/actions/create-report/create-report.mjs Version updated from "0.0.3" to "0.0.4".
components/linkedin_ads/actions/send-conversion-event/send-conversion-event.mjs Version updated from "0.0.2" to "0.0.3".
components/linkedin_ads/sources/new-event-registration-form-response/new-event-registration-form-response.mjs Version updated from "0.0.2" to "0.0.3".
components/linkedin_ads/sources/new-lead-gen-form-created/new-lead-gen-form-created.mjs Version updated from "0.0.1" to "0.0.2".
components/linkedin_ads/linkedin_ads.app.mjs New properties added: adAccountId, campaignId, accounts, eventId, conversionId, leadFormId. Methods updated to remove debug: true.
components/linkedin_ads/package.json Version updated from "0.3.0" to "0.3.1". Dependency added: "@pipedream/platform": "^3.0.3".

Assessment against linked issues

Objective Addressed Explanation
Update LinkedIn integration to use a supported API version (#[14346]) The PR does not address the API version issue directly.

Possibly related PRs

Suggested labels

bug, User submitted

Suggested reviewers

  • jcortes

Poem

In the fields where data flows,
New versions bloom like springtime shows.
With properties fresh and requests refined,
LinkedIn Ads, your growth we find!
Hop along, let's share the cheer,
For every change brings progress near! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6da9785 and e095e62.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • components/linkedin_ads/actions/create-report-by-advertiser-account/create-report-by-advertiser-account.mjs (1 hunks)
  • components/linkedin_ads/actions/create-report-by-campaign/create-report-by-campaign.mjs (1 hunks)
  • components/linkedin_ads/actions/create-report/create-report.mjs (1 hunks)
  • components/linkedin_ads/actions/send-conversion-event/send-conversion-event.mjs (1 hunks)
  • components/linkedin_ads/linkedin_ads.app.mjs (0 hunks)
  • components/linkedin_ads/package.json (1 hunks)
  • components/linkedin_ads/sources/new-event-registration-form-response/new-event-registration-form-response.mjs (1 hunks)
  • components/linkedin_ads/sources/new-lead-gen-form-created/new-lead-gen-form-created.mjs (1 hunks)
💤 Files with no reviewable changes (1)
  • components/linkedin_ads/linkedin_ads.app.mjs
✅ Files skipped from review due to trivial changes (6)
  • components/linkedin_ads/actions/create-report-by-advertiser-account/create-report-by-advertiser-account.mjs
  • components/linkedin_ads/actions/create-report-by-campaign/create-report-by-campaign.mjs
  • components/linkedin_ads/actions/create-report/create-report.mjs
  • components/linkedin_ads/actions/send-conversion-event/send-conversion-event.mjs
  • components/linkedin_ads/sources/new-event-registration-form-response/new-event-registration-form-response.mjs
  • components/linkedin_ads/sources/new-lead-gen-form-created/new-lead-gen-form-created.mjs
🧰 Additional context used
🔇 Additional comments (3)
components/linkedin_ads/package.json (3)

3-3: LGTM: Version update aligns with PR objectives.

The version increment from 0.3.0 to 0.3.1 is appropriate for updating the LinkedIn Ads components to reflect the API version change.


15-16: Please clarify the purpose of the new dependency.

A new dependency on "@pipedream/platform" version "^3.0.3" has been added. Can you explain how this relates to the API version update mentioned in the PR objectives? Also, please ensure that this dependency is compatible with the updated LinkedIn API version.

#!/bin/bash
# Description: Check for usage of @pipedream/platform in the codebase

# Test: Search for imports of @pipedream/platform
echo "Files importing @pipedream/platform:"
rg -l "from ['\"]\@pipedream/platform['\"]" components/linkedin_ads/

# Test: Check if the specified version exists in the npm registry
if npm view @pipedream/platform@^3.0.3 version &> /dev/null; then
    echo "Version ^3.0.3 of @pipedream/platform exists in the npm registry"
else
    echo "Version ^3.0.3 of @pipedream/platform does not exist in the npm registry"
fi

14-14: Verify the removal of the "files" array.

The AI summary mentioned the removal of the "files" array, which previously included "dist". This change is not visible in the provided code snippet. Please confirm if this removal was intentional and if it affects how the package will be published.

✅ Verification successful

Verified the removal of the "files" array from components/linkedin_ads/package.json.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for the presence of a "files" field in the package.json

# Test: Look for "files" field in package.json
if jq -e '.files' components/linkedin_ads/package.json > /dev/null 2>&1; then
    echo "The 'files' field is still present in package.json"
else
    echo "The 'files' field has been removed from package.json"
fi

Length of output: 469


Script:

#!/bin/bash
# Description: Verify the removal of the "files" array in package.json

if jq -e '.files' components/linkedin_ads/package.json > /dev/null 2>&1; then
    echo "The 'files' array is present in package.json."
else
    echo "The 'files' array has been removed from package.json."
fi

Length of output: 174


Script:

#!/bin/bash
# Description: Check for the presence of the "dist" directory in components/linkedin_ads

if [ -d "components/linkedin_ads/dist" ]; then
    echo "The 'dist' directory exists in components/linkedin_ads."
else
    echo "The 'dist' directory does not exist in components/linkedin_ads."
fi

Length of output: 184


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michelle0927 michelle0927 merged commit c321846 into master Oct 23, 2024
12 checks passed
@michelle0927 michelle0927 deleted the issue-14346 branch October 23, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LinkedIn Ads

3 participants