Skip to content

Microsoft OneDrive - add streaming support to upload file action #15861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

Microsoft OneDrive - add streaming support to upload file action #15861

merged 2 commits into from
Mar 11, 2025

Conversation

@andrewjschuang
Copy link
Contributor

@andrewjschuang andrewjschuang commented Mar 11, 2025 •
edited by coderabbitai bot
Loading

Resolves #15845.

Summary by CodeRabbit

  • Refactor
    • Enhanced file upload processing by leveraging a more efficient streaming approach for better performance and memory usage.
  • Chores
    • Updated version numbers for improved consistency and component stability.

@vercel
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Mar 11, 2025 5:39pm
pipedream-docs ⬜️ Ignored (Inspect) Mar 11, 2025 5:39pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Mar 11, 2025 5:39pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 11, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request updates the file upload functionality for the OneDrive component. It replaces the use of fileTypeFromBuffer with fileTypeFromStream and changes file reading from a buffer (fs.readFileSync) to using a stream (fs.createReadStream). The stream is destroyed and recreated to facilitate reprocessing for file type detection before upload. Additionally, version numbers are incremented in both the action file and the package manifest.

Changes

File(s) Change Summary
components/microsoft_onedrive/actions/upload-file/upload-file.mjs Switched from buffer-based to stream-based file reading; replaced fileTypeFromBuffer with fileTypeFromStream; recreated stream after file type detection; version updated from 0.1.1 to 0.1.2.
components/microsoft_onedrive/package.json Incremented component version from 1.6.0 to 1.6.1.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant M as Upload Module
    participant FS as File System
    participant DS as FileType Detector

    U->>M: Initiate file upload
    M->>FS: Create read stream from filePath
    M->>DS: Determine file type from stream
    DS-->>M: Return file type info
    M->>FS: Destroy stream
    M->>FS: Recreate read stream for upload
    M->>M: Upload file using new stream
    M-->>U: Return upload status
Loading

Possibly related PRs

Suggested labels

enhancement, action

Suggested reviewers

  • michelle0927

Poem

Hop, hop, hop, I scurry along the stream,
Replacing buffers with a flowing dream.
A river of bytes, fresh and new,
Each version bump brings a brighter view.
I, the rabbit, celebrate with glee,
Hopping through code in pure jubilee!
🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

Scope: all 2 workspace projects
 ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS  Optional dependencies cannot be installed without production dependencies

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de3be06 and d382cfb.

📒 Files selected for processing (2)
  • components/microsoft_onedrive/actions/upload-file/upload-file.mjs (2 hunks)
  • components/microsoft_onedrive/package.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@andrewjschuang andrewjschuang changed the title Microsoft OneDrive - fix upload file Microsoft OneDrive - add streaming support to upload file action Mar 11, 2025
@andrewjschuang andrewjschuang merged commit 6ae6d67 into master Mar 11, 2025
10 of 11 checks passed
@andrewjschuang andrewjschuang deleted the onedrive-fix-upload-file branch March 11, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Microsoft OneDrive Upload File action not streaming

2 participants

@andrewjschuang