[Gmail] fix hanging trigger #16167

andrewjschuang · 2025-04-03T21:24:46Z

WHY

Issues with OOM in New Attachment Received trigger execution (or potentially payload limit exceeded)

Summary by CodeRabbit

Chores
- Standardized version updates across multiple Gmail components.
New Features
- Added a mechanism to actively trigger polling for new messages.
Refactor
- Updated the authentication workflow for smoother Gmail integration.
- Optimized event handling for email attachments by cleaning up unnecessary data during processing.

vercel · 2025-04-03T21:24:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments

Name	Status	Preview	Updated (UTC)
docs-v2	⬜️ Ignored (Inspect)	Visit Preview	Apr 3, 2025 9:26pm
pipedream-docs	⬜️ Ignored (Inspect)		Apr 3, 2025 9:26pm
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)		Apr 3, 2025 9:26pm

coderabbitai · 2025-04-03T21:24:54Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates version numbers across several Gmail action and source modules. There is an update to the authentication method in the Gmail app that now uses the google-auth-library’s JWT constructor with named parameters for credentials and impersonation. Additionally, a new asynchronous activate method has been added to the polling module to log and update the last fetched date. Minor behavior changes include the removal of a property in one source module without altering overall functionality.

Changes

File(s)	Change Summary
`components/gmail/actions/...` (add-label-to-email, approve-workflow, create-draft, download-attachment, find-email, list-labels, remove-label-from-email, send-email, update-org-signature, update-primary-signature)	Updated version numbers (e.g., 0.0.6→0.0.7, 0.0.2→0.0.3, etc.) with no functional changes.
`components/gmail/gmail.app.mjs`	Modified service account authentication to use `google-auth-library`’s JWT constructor with an object (includes `email`, `key`, and `subject`) for credentials.
`components/gmail/package.json`	Package version bumped from 0.2.4 to 0.2.5.
`components/gmail/sources/...` (polling-messages, new-attachment-received, new-email-matching-search, new-email-received, new-labeled-email, new-sent-email)	Updated version numbers; added an `async activate()` method to polling-messages; in new-attachment-received, removed the `payload` property in the `emitEvent` method.

Sequence Diagram(s)

sequenceDiagram
    participant GmailApp
    participant JWT_Lib
    GmailApp->>JWT_Lib: _serviceAccountAuth({email, key, subject})
    JWT_Lib-->>GmailApp: Return JWT instance

sequenceDiagram
    participant PollingSource
    participant LastDateStore
    PollingSource->>LastDateStore: getLastDate()
    LastDateStore-->>PollingSource: returns previousDate
    PollingSource->>Console: Log previous date
    PollingSource->>LastDateStore: setLastDate(Date.now())
    LastDateStore-->>PollingSource: Confirmation

Poem

Hoppin' through the code with glee,
I see new versions hopping free.
JWT now leaps in a modern way,
While polling wakes to greet the day.
My whiskers twitch in every line—
Celebrating changes, oh so fine!
🐇💻

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/gmail/actions/approve-workflow/approve-workflow.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/gmail/actions/add-label-to-email/add-label-to-email.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

components/gmail/actions/download-attachment/download-attachment.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at packageResolve (node:internal/modules/esm/resolve:839:9)
at moduleResolve (node:internal/modules/esm/resolve:908:18)
at defaultResolve (node:internal/modules/esm/resolve:1038:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:557:12)
at ModuleLoader.resolve (node:internal/modules/esm/loader:525:25)
at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:246:38)
at ModuleJob._link (node:internal/modules/esm/module_job:126:49)

14 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5b2d91 and 7e82f9e.

📒 Files selected for processing (18)

components/gmail/actions/add-label-to-email/add-label-to-email.mjs (1 hunks)
components/gmail/actions/approve-workflow/approve-workflow.mjs (1 hunks)
components/gmail/actions/create-draft/create-draft.mjs (1 hunks)
components/gmail/actions/download-attachment/download-attachment.mjs (1 hunks)
components/gmail/actions/find-email/find-email.mjs (1 hunks)
components/gmail/actions/list-labels/list-labels.mjs (1 hunks)
components/gmail/actions/remove-label-from-email/remove-label-from-email.mjs (1 hunks)
components/gmail/actions/send-email/send-email.mjs (1 hunks)
components/gmail/actions/update-org-signature/update-org-signature.mjs (1 hunks)
components/gmail/actions/update-primary-signature/update-primary-signature.mjs (1 hunks)
components/gmail/gmail.app.mjs (2 hunks)
components/gmail/package.json (1 hunks)
components/gmail/sources/common/polling-messages.mjs (1 hunks)
components/gmail/sources/new-attachment-received/new-attachment-received.mjs (2 hunks)
components/gmail/sources/new-email-matching-search/new-email-matching-search.mjs (1 hunks)
components/gmail/sources/new-email-received/new-email-received.mjs (1 hunks)
components/gmail/sources/new-labeled-email/new-labeled-email.mjs (1 hunks)
components/gmail/sources/new-sent-email/new-sent-email.mjs (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

andrewjschuang added 3 commits April 3, 2025 18:04

use smaller auth library

8daab94

reset the last date in activate hook

6b56e86

remove payload from emit

f37d997

bump versions

7e82f9e

andrewjschuang merged commit f642a57 into master Apr 3, 2025
10 checks passed

andrewjschuang deleted the gmail-fix-hanging-trigger branch April 3, 2025 21:28

coderabbitai bot mentioned this pull request May 28, 2025

[ACTION] Gmail Find Email actions return too much text #16824 #16830

Merged

coderabbitai bot mentioned this pull request Jun 21, 2025

17235 source gmail sources return too much text #17236

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Gmail] fix hanging trigger #16167

[Gmail] fix hanging trigger #16167

Uh oh!

andrewjschuang commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[Gmail] fix hanging trigger #16167

[Gmail] fix hanging trigger #16167

Uh oh!

Conversation

andrewjschuang commented Apr 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY

Summary by CodeRabbit

Uh oh!

vercel bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrewjschuang commented Apr 3, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Apr 3, 2025 •

edited

Loading

coderabbitai bot commented Apr 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)