-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Updating notion-to-md to use stable version #16357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update includes a version bump for the "Retrieve Page Content" action and the overall Notion integration package. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/notion/actions/retrieve-block/retrieve-block.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (19)
components/notion/actions/append-block/append-block.mjs(1 hunks)components/notion/actions/create-comment/create-comment.mjs(1 hunks)components/notion/actions/create-page-from-database/create-page-from-database.mjs(1 hunks)components/notion/actions/create-page/create-page.mjs(1 hunks)components/notion/actions/duplicate-page/duplicate-page.mjs(1 hunks)components/notion/actions/query-database/query-database.mjs(1 hunks)components/notion/actions/retrieve-block/retrieve-block.mjs(2 hunks)components/notion/actions/retrieve-database-content/retrieve-database-content.mjs(1 hunks)components/notion/actions/retrieve-database-schema/retrieve-database-schema.mjs(1 hunks)components/notion/actions/retrieve-page-property-item/retrieve-page-property-item.mjs(1 hunks)components/notion/actions/retrieve-page/retrieve-page.mjs(1 hunks)components/notion/actions/search/search.mjs(1 hunks)components/notion/actions/update-page/update-page.mjs(1 hunks)components/notion/sources/new-comment-created/new-comment-created.mjs(1 hunks)components/notion/sources/new-database/new-database.mjs(1 hunks)components/notion/sources/new-page/new-page.mjs(1 hunks)components/notion/sources/page-or-subpage-updated/page-or-subpage-updated.mjs(1 hunks)components/notion/sources/updated-page-id/updated-page-id.mjs(1 hunks)components/notion/sources/updated-page/updated-page.mjs(1 hunks)
✅ Files skipped from review due to trivial changes (18)
- components/notion/sources/new-database/new-database.mjs
- components/notion/sources/new-comment-created/new-comment-created.mjs
- components/notion/actions/create-page-from-database/create-page-from-database.mjs
- components/notion/actions/update-page/update-page.mjs
- components/notion/actions/search/search.mjs
- components/notion/actions/query-database/query-database.mjs
- components/notion/actions/create-comment/create-comment.mjs
- components/notion/actions/retrieve-page-property-item/retrieve-page-property-item.mjs
- components/notion/actions/retrieve-page/retrieve-page.mjs
- components/notion/actions/retrieve-database-schema/retrieve-database-schema.mjs
- components/notion/actions/create-page/create-page.mjs
- components/notion/actions/duplicate-page/duplicate-page.mjs
- components/notion/sources/updated-page-id/updated-page-id.mjs
- components/notion/sources/page-or-subpage-updated/page-or-subpage-updated.mjs
- components/notion/actions/append-block/append-block.mjs
- components/notion/sources/updated-page/updated-page.mjs
- components/notion/sources/new-page/new-page.mjs
- components/notion/actions/retrieve-database-content/retrieve-database-content.mjs
🧰 Additional context used
🪛 GitHub Check: Lint Code Base
components/notion/actions/retrieve-block/retrieve-block.mjs
[warning] 7-7:
{{ts}} macro should be removed before committing
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Verify TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
🔇 Additional comments (1)
components/notion/actions/retrieve-block/retrieve-block.mjs (1)
43-48: LGTM: Improved markdown generation with conditional children retrievalThe change correctly implements the ability to conditionally include child blocks in markdown output by passing the
shouldRetrieveChildrenboolean to the refactoredgetPageAsMarkdownmethod. This aligns with the PR objective of updating to the stable version of notion-to-md.
Summary by CodeRabbit