Skip to content

Fix missing Slack lodash, async-retry dependencies #16375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 20, 2025
Merged

Fix missing Slack lodash, async-retry dependencies #16375

merged 2 commits into from
Apr 20, 2025

Conversation

@js07
Copy link
Collaborator

@js07 js07 commented Apr 20, 2025 •
edited by coderabbitai bot
Loading

This pull request updates the @pipedream/slack package to include missing dependencies.

Dependency Updates:

  • Updated the version of the @pipedream/slack package from 0.9.4 to 0.9.5 in components/slack/package.json.
  • Added async-retry (v1.3.3) and lodash (v4.17.21) as dependencies in components/slack/package.json.

WHY

When I try to import the @pipedream/slack package in a code step, I get the following error:

Error: Cannot find package 'lodash' imported from /tmp/pdg/dist/code/f1b2329d446b8b50f30b8ce29f0bf99483a4340aa9383d3a85d19024f1055c3f/node_modules/.pnpm/@[[email protected]](mailto:[email protected])/node_modules/@pipedream/slack/slack.app.mjs

The lodash and async-retry packages are imported in components/slack/slack.app.mjs but not included as dependencies in components/slack/package.json.

Summary by CodeRabbit

  • Chores
    • Updated package version to 0.9.5.
    • Added new dependencies to improve reliability and utility.

@js07 js07 added the bug Something isn't working label Apr 20, 2025
@vercel
Copy link

vercel bot commented Apr 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Apr 20, 2025 9:53pm
pipedream-docs ⬜️ Ignored (Inspect) Apr 20, 2025 9:53pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Apr 20, 2025 9:53pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 20, 2025 •
edited
Loading

Walkthrough

The package configuration for the Slack component was updated. The version number was incremented from 0.9.4 to 0.9.5. Additionally, two new dependencies, async-retry and lodash, were added to the package's dependencies list. No changes were made to exported or public entities, and no other configuration or metadata was altered.

Changes

File(s) Change Summary
components/slack/package.json Bumped package version to 0.9.5; added async-retry and lodash as dependencies.

Poem

A hop, a skip, a version jump,
Two new friends join the codey clump—
async-retry and lodash too,
Helping Slack do what it must do.
With 0.9.5, we leap ahead,
Onward, forward—enough said!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)
  • We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@js07 js07 marked this pull request as ready for review April 20, 2025 22:07
@js07 js07 moved this to Ready for PR Review in Component (Source and Action) Backlog Apr 20, 2025
coderabbitai[bot]
coderabbitai bot reviewed Apr 20, 2025
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/slack/package.json (1)

20-20: Approve addition of lodash
Including lodash@^4.17.21 resolves the import error. For bundle‑size optimization, consider importing only specific functions (e.g., import get from 'lodash/get') if tree‑shaking isn’t fully effective.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74dd14f and b5d2ab5.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • components/slack/package.json (2 hunks)
🔇 Additional comments (3)
components/slack/package.json (3)

3-3: Confirm version bump to 0.9.5
The package version was correctly incremented from 0.9.4 to 0.9.5. Ensure you’ve updated any related CHANGELOG or release notes as per your release workflow.

18-18: Verify @slack/web-api version upgrade
The dependency @slack/web-api is now set to ^7.9.0. Please confirm that this upgrade is backward‑compatible with existing Slack component logic and doesn’t introduce breaking changes.

19-19: Approve addition of async-retry
Adding async-retry@^1.3.3 satisfies the missing import in slack.app.mjs. After installation, run the retry flows or unit tests to validate the retry behavior.

@js07 js07 merged commit a82ea43 into master Apr 20, 2025
11 checks passed
@js07 js07 deleted the fix-slack-missing-lodash-import branch April 20, 2025 23:18
@github-project-automation github-project-automation bot moved this from Ready for PR Review to Done in Component (Source and Action) Backlog Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@dannyroosevelt dannyroosevelt dannyroosevelt approved these changes

@GTFalcao GTFalcao Awaiting requested review from GTFalcao

Assignees

No one assigned

Labels

bug Something isn't working

Projects

Component (Source and Action) Backlog
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@js07 @dannyroosevelt