-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Danny/connect deployed triggers docs patch #16397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danny/connect deployed triggers docs patch #16397
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe changes update API documentation and example code snippets related to deployed triggers. The API documentation now specifies a new optional path parameter, Changes
Sequence Diagram(s)sequenceDiagram
User -> API: GET /deployed-triggers/{emitter_type}?external_user_id=...
API -> Database: Query deployed triggers (filtered by emitter_type if provided)
Database --> API: Return list of deployed triggers
API --> User: Return filtered deployed triggers
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs-v2/pages/connect/api.mdx (1)
2250-2264: Clarify optionalemitter_typepath parameter usage
The{emitter_type}segment is presented as optional, but only one URL form (/deployed-triggers/{emitter_type}) is shown. Consider explicitly documenting both forms—GET /deployed-triggers(defaulting tosource) andGET /deployed-triggers/{emitter_type}—or call out that omitting the segment defaults to thesourcetype. This will remove ambiguity around how to filter by emitter type.docs-v2/pages/connect/components.mdx (1)
925-927: Add context for omittedendpoint_urlin schedule triggers
You’ve correctly removed theendpoint_urlalias for schedule-based triggers since the API response doesn't include that field. To preempt confusion, consider adding a brief note (or callout) explaining that native schedule triggers don’t emit anendpoint_urland therefore only theidis returned.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
docs-v2/pages/connect/api.mdx(1 hunks)docs-v2/pages/connect/components.mdx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: Lint Code Base
- GitHub Check: validate-links
WHY
Summary by CodeRabbit