components/offorte/package.json (1)

3-17: Pin platform dependency to an exact minor to avoid future breakage

Using a caret (^3.1.0) means any 3.x release will be installed. Pipedream platform updates sometimes introduce breaking changes; consider pinning to ~3.1.0 (patch-level) or an exact version until the integration is proven compatible.

-    "@pipedream/platform": "^3.1.0"
+    "@pipedream/platform": "~3.1.0"

components/offorte/actions/list-proposals/list-proposals.mjs (1)

20-26: Handle non-array API responses as with templates action

Similar to the template listing action, guard against the API returning an object envelope.

-    $.export("$summary", `Successfully fetched ${response.length} proposals`);
+    const count = Array.isArray(response) ? response.length : response?.data?.length ?? 0;
+    $.export("$summary", `Successfully fetched ${count} proposals`);

components/offorte/actions/create-contact-person/create-contact-person.mjs (1)

140-155: Same array-vs-parseObject concern for tags

See previous comments – using parseObject on an already-array input will throw.

components/offorte/actions/search-contact-organisation/search-contact-organisation.mjs (1)

17-26: Same response-shape concern as contact people search

Mirrors the previous comment – double-check the API returns an array.

components/offorte/sources/new-event-instant/test-event.mjs (1)

1-5: Confirm epoch accuracy and add newline

The hard-coded timestamp (1718534400) represents seconds, whereas other integrations sometimes expect milliseconds. Double-check the downstream consumer of ts; if milliseconds are required, multiply by 1_000.

Also add a trailing newline to adhere to POSIX text-file conventions.

components/offorte/package.json (1)

12-14: Add missing fields for public NPM packages

repository, license, and engines are currently absent. Including them improves discoverability and compliance with open-source requirements.

components/offorte/actions/list-proposals/list-proposals.mjs (1)

13-17: Expose default / required value for status prop

If status is optional at the API level, consider adding optional: true or setting a sensible default; otherwise mark it required: true to guide users in the UI.

components/offorte/actions/create-contact-organisation/create-contact-organisation.mjs (1)

122-149: Minor: many address fields are required by default

street, zipcode, city, state, country are most likely optional in Offorte.
Not marking them with optional: true forces the UI to ask for unnecessary data and blocks valid requests.

components/offorte/actions/create-proposal/create-proposal.mjs (1)

61-72: status is mandatory but undocumented as required

Unlike other optional props, status lacks optional: true, making it compulsory in the UI even though the API accepts a default (concept). Either mark it optional or document the requirement explicitly.

components/offorte/actions/create-contact-person/create-contact-person.mjs (1)

1-3: Shadowing the imported offorte identifier

You import offorte (the app) and later destructure offorte from this, shadowing the original binding. While it works, it decreases readability and may trip IDE tooling. Recommend renaming the destructured variable:

-const {
-  offorte,
+const {
+  offorte: offorteClient,

components/offorte/sources/new-event-instant/new-event-instant.mjs (2)

25-35: Consider persisting the full webhook object

Only the webhook_id is stored. Persisting the full response (or at least the secret) aids debugging and later updates.

---

41-46: Use numeric timestamp not Date.parse

Date.parse returns NaN on invalid input and assumes UTC.
If body.date_created is already ISO-8601, convert with new Date(...).
Otherwise expose parsing failures.

-  ts: Date.parse(body.date_created),
+  ts: new Date(body.date_created).getTime(),

components/offorte/common/constants.mjs (1)

1-116: Consider freezing exported option arrays to prevent accidental runtime mutation

These option arrays are intended to be treated as enums. Freezing them (e.g. export const STATUS_OPTIONS = Object.freeze([...])) makes accidental writes during runtime impossible and signals immutability to future maintainers.

-export const STATUS_OPTIONS = [
+export const STATUS_OPTIONS = Object.freeze([
   { label: "Edit",  value: "edit"  },
   ...
-];
+]);

Replicate for the other two arrays.

This is a low-effort, forward-looking hardening step.

components/offorte/common/utils.mjs (1)

1-24: parseObject silently swallows JSON.parse errors – log or bubble?

If malformed JSON is passed, the current implementation eats the exception and returns the original string, making debugging hard. At minimum, consider console.debug-level logging so integrators can trace bad input.

components/offorte/actions/send-proposal/send-proposal.mjs (1)

59-61: Error message typo – align prop name

The thrown message uses back-ticks around Send Message Id, but the prop is Send Message ID (sendMessageId). Consistency helps users map UI → error.

components/offorte/offorte.app.mjs (2)

33-41: Consider returning consistent option format for tags.

The tags prop returns an array of strings (names only), while other prop definitions return objects with label and value properties. For consistency, consider returning the same format.

     tags: {
       type: "string[]",
       label: "Tags",
       description: "The tags of the contact",
       async options() {
         const response = await this.listTags();
-        return response.map(({ name }) => name);
+        return response.map(({ name }) => ({
+          label: name,
+          value: name,
+        }));
       },
     },

---

226-233: Remove unnecessary trailing slash in the API path.

The path includes a trailing slash which might cause issues or be redundant.

     listProposals({
       status, ...opts
     }) {
       return this._makeRequest({
-        path: `/proposals/${status}/`,
+        path: `/proposals/${status}`,
         ...opts,
       });
     },

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

components/offorte/offorte.app.mjs (1)

152-157: listUsers (and all list helpers) lack pagination and filtering*

With the _makeRequest fix you’ll now get an array, but large workspaces can exceed default limits.
Introduce page/page_size parameters or document their absence.

This was raised in an earlier review and is still outstanding.

components/offorte/offorte.app.mjs (1)

234-237: Trailing slash in listProposals path may break some HTTP clients

/proposals/${status}/ produces a double “//” when status is empty and an unnecessary trailing slash otherwise. Safe variant:

-return this._makeRequest({
-  path: `/proposals/${status}/`,
+return this._makeRequest({
+  path: `/proposals/${status}`,

Minor, but avoids 301s/404s depending on the API router.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

components/offorte/sources/new-event-instant/test-event.mjs (1)

1-1: Nit: add trailing newline at EOF for POSIX compatibility

While harmless at runtime, adding a terminal newline keeps git diff noise down and aligns with the repo’s style.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

components/offorte/offorte.app.mjs (2)

11-17: response.map still explodes – option loader expects an array but receives the raw Axios response

this.listContacts() returns the full Axios response object, so response.map throws TypeError: response.map is not a function.
Root cause is _makeRequest returning the whole response instead of response.data.

---

203-211: Return response.data and add basic error handling in _makeRequest

Without unwrapping the data, every consumer must remember to access response.data, which is already causing runtime crashes in the option loaders.
Wrapping the call in a try/catch also surfaces meaningful errors.

-    _makeRequest({
-      $ = this, path, ...opts
-    }) {
-      return axios($, {
-        url: this._baseUrl() + path,
-        headers: this._headers(),
-        ...opts,
-      });
-    },
+    async _makeRequest({
+      $ = this, path, ...opts
+    }) {
+      try {
+        const { data } = await axios($, {
+          url: this._baseUrl() + path,
+          headers: this._headers(),
+          ...opts,
+        });
+        return data;
+      } catch (error) {
+        const msg = error.response
+          ? `${error.response.status} ${error.response.statusText}`
+          : error.message;
+        throw new Error(`Offorte API request failed: ${msg}`);
+      }
+    },

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro