-
Notifications
You must be signed in to change notification settings - Fork 5.5k
17079 trigger trengo voice call recorded #17177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17079 trigger trengo voice call recorded #17177
Conversation
Sources - Voice Call Recorded
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update introduces a new Trengo source trigger for "VOICE_CALL_RECORDED" events, including a test event and event metadata logic. Additionally, several Trengo actions and sources have their version numbers incremented, and minor metadata and import order adjustments are made. No other functional changes are present. Changes
Sequence Diagram(s)sequenceDiagram
participant Trengo as Trengo Platform
participant Source as VOICE_CALL_RECORDED Source
participant User as User
Trengo->>Source: Emits VOICE_CALL_RECORDED event
Source->>Source: getMeta(event) extracts metadata
Source->>User: Emits processed event with summary and metadata
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/trengo/sources/voice-call-recorded/voice-call-recorded.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
components/trengo/sources/new-internal-note/new-internal-note.mjs (1)
19-19: Fix summary text typo
The summary currently reads “New ticket label added event…” but this is the Internal Note source. Update to something like:- summary: `New ticket label added event: ${event?.body?.message}`, + summary: `New internal note event: ${event?.body?.message}`,
🧹 Nitpick comments (2)
components/trengo/sources/new-outbound-message/new-outbound-message.mjs (1)
19-19: Typo in summary string
“outbund” should be “outbound”. Recommend:- summary: `New outbund message event: ${event?.body?.message}`, + summary: `New outbound message event: ${event?.body?.message}`,components/trengo/sources/phone-call-missed/phone-call-missed.mjs (1)
6-6: Grammar in description
Change “when an phone call missed” to “when a phone call is missed” for clarity:- description: "Emit new events when an phone call missed.…", + description: "Emit new events when a phone call is missed.…",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (16)
components/trengo/actions/create-contact/create-contact.mjs(1 hunks)components/trengo/actions/find-contacts/find-contacts.mjs(1 hunks)components/trengo/actions/log-a-voice-call/log-a-voice-call.mjs(1 hunks)components/trengo/actions/send-a-message/send-a-message.mjs(1 hunks)components/trengo/actions/send-a-team-chat-message/send-a-team-chat-message.mjs(1 hunks)components/trengo/actions/send-a-whatsapp-message-template/send-a-whatsapp-message-template.mjs(1 hunks)components/trengo/package.json(2 hunks)components/trengo/sources/new-inbound-message/new-inbound-message.mjs(1 hunks)components/trengo/sources/new-internal-note/new-internal-note.mjs(1 hunks)components/trengo/sources/new-outbound-message/new-outbound-message.mjs(1 hunks)components/trengo/sources/phone-call-ended/phone-call-ended.mjs(1 hunks)components/trengo/sources/phone-call-missed/phone-call-missed.mjs(1 hunks)components/trengo/sources/phone-call-started/phone-call-started.mjs(1 hunks)components/trengo/sources/ticket-label-added/ticket-label-added.mjs(1 hunks)components/trengo/sources/voice-call-recorded/test-event.mjs(1 hunks)components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (23)
components/trengo/package.json (2)
3-3: Bump component version to 0.1.0.
Minor version bump aligns with the introduction of new features and the tracked issue resolution.
13-13: Upgrade@pipedream/platformdependency to ^3.1.0.
This is a major version bump—please verify that all existing actions and sources remain compatible with the updated platform API.components/trengo/actions/log-a-voice-call/log-a-voice-call.mjs (1)
6-6: Increment action version to 0.0.2.
Version bump is consistent with other Trengo actions in this PR. No functional changes detected.components/trengo/actions/create-contact/create-contact.mjs (1)
6-6: Increment action version to 0.0.2.
This aligns with the coordinated version bump across Trengo actions.components/trengo/actions/send-a-message/send-a-message.mjs (1)
6-6: Increment action version to 0.0.2.
Consistent version update; no logic changes.components/trengo/sources/phone-call-started/phone-call-started.mjs (1)
5-7: Suffix event name with “(Instant)” and bump version to 0.0.2.
Display name change and version increment are in line with other source updates in this PR.components/trengo/sources/new-internal-note/new-internal-note.mjs (2)
5-5: Append “(Instant)” suffix to source name
Name updated to “New Internal Note Event (Instant)” for consistency with other Trengo sources.
7-7: Bump version to “0.0.2”
Version increment aligns with coordinated metadata updates across all Trengo components.components/trengo/sources/ticket-label-added/ticket-label-added.mjs (2)
5-5: Append “(Instant)” suffix to source name
Consistent naming applied: “New Ticket Label Added Event (Instant)”.
7-7: Bump version to “0.0.2”
Matches the version bump strategy used across all Trengo sources in this PR.components/trengo/sources/new-outbound-message/new-outbound-message.mjs (2)
5-5: Append “(Instant)” suffix to source name
“New Outbound Message Event (Instant)” aligns with other event definitions.
7-7: Bump version to “0.0.2”
Version update is in lockstep with related source components.components/trengo/sources/phone-call-missed/phone-call-missed.mjs (2)
5-5: Append “(Instant)” suffix to source name
Updated to “New Phone Call Missed Event (Instant)” for consistency.
7-7: Bump version to “0.0.2”
Version bump aligns with mass update across Trengo sources.components/trengo/sources/phone-call-ended/phone-call-ended.mjs (2)
5-5: Append “(Instant)” suffix to source name
Consistent suffix applied: “New Phone Call Ended Event (Instant)”.
7-7: Bump version to “0.0.2”
Matches version updates across other Trengo components.components/trengo/sources/new-inbound-message/new-inbound-message.mjs (1)
5-5: LGTM! Consistent metadata updates.The name clarification with "(Instant)" and version increment align well with the PR's broader component updates.
Also applies to: 7-7
components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs (1)
1-24: LGTM! Well-structured new voice call recorded trigger.The implementation follows established Trengo source patterns and correctly extracts event metadata. The summary format is informative and the event type is clearly defined.
components/trengo/sources/voice-call-recorded/test-event.mjs (1)
1-13: LGTM! Comprehensive test event data.The test event provides all necessary fields with realistic data that aligns with the voice call recorded source component's metadata extraction logic.
components/trengo/actions/send-a-team-chat-message/send-a-team-chat-message.mjs (1)
2-2: LGTM! Consistent maintenance updates.The import reordering and version increment are part of the coordinated component updates across the PR.
Also applies to: 7-7
components/trengo/actions/send-a-whatsapp-message-template/send-a-whatsapp-message-template.mjs (1)
2-2: LGTM! Consistent maintenance updates.The import reordering and version increment align with the coordinated component updates throughout this PR.
Also applies to: 7-7
components/trengo/actions/find-contacts/find-contacts.mjs (2)
2-2: LGTM! Import reordering for consistency.The import statement reordering doesn't affect functionality and likely improves code organization consistency across the project.
7-7: LGTM! Appropriate version increment.The patch version bump from 0.0.1 to 0.0.2 is appropriate for the minor changes made and aligns with the coordinated version updates across Trengo components.
components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs
Outdated
Show resolved
Hide resolved
michelle0927
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* [TRIGGER] Trengo - VOICE_CALL_RECORDED PipedreamHQ#17079 Sources - Voice Call Recorded * update pnpm-lock.yaml * Update components/trengo/sources/voice-call-recorded/voice-call-recorded.mjs --------- Co-authored-by: michelle0927 <[email protected]>
Resolves #17079
Summary by CodeRabbit
New Features
Improvements