-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[FIX] Support file URLS and file paths in a single prop input deployment #17397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Support file URLS and file paths in a single prop input deployment #17397
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe updates rename props for zone identification and setting values in two Cloudflare action components, replacing external constant dependencies with inline options. Documentation URLs are updated, summary messages simplified, and the package version is incremented from 1.0.1 to 1.0.2. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/cloudflare_api_key/actions/update-zone-security-level/update-zone-security-level.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/cloudflare_api_key/actions/change-zone-development-mode/change-zone-development-mode.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
6e0350f to
742b4d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
components/cloudflare_api_key/actions/change-zone-development-mode/change-zone-development-mode.mjs(2 hunks)components/cloudflare_api_key/actions/update-zone-security-level/update-zone-security-level.mjs(2 hunks)components/cloudflare_api_key/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
components/cloudflare_api_key/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/cloudflare_api_key/actions/change-zone-development-mode/change-zone-development-mode.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/cloudflare_api_key/actions/update-zone-security-level/update-zone-security-level.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Lint Code Base
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (3)
components/cloudflare_api_key/package.json (1)
3-3: Version bump looks appropriate, but verify PR objectives alignment.The patch version increment from 1.0.0 to 1.0.1 is appropriate for the changes described. However, there's a significant mismatch between the PR objectives (fixing file URLs/paths in deployment) and the actual changes (Cloudflare API modifications).
Likely an incorrect or invalid review comment.
components/cloudflare_api_key/actions/change-zone-development-mode/change-zone-development-mode.mjs (1)
6-6: Documentation URL updated appropriately.The description now references the correct Cloudflare API documentation for zone settings.
components/cloudflare_api_key/actions/update-zone-security-level/update-zone-security-level.mjs (1)
6-6: Documentation URL updated appropriately.The description now references the correct Cloudflare API documentation for zone settings.
...nts/cloudflare_api_key/actions/change-zone-development-mode/change-zone-development-mode.mjs
Show resolved
Hide resolved
components/cloudflare_api_key/actions/update-zone-security-level/update-zone-security-level.mjs
Show resolved
Hide resolved
19fa195 to
26ee38d
Compare
26ee38d to
fec9081
Compare
WHY
Resolves deployment error in #17169
Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Chores