components/devin/devin.app.mjs (3)

85-89: Nit: clean up pinnedRepo description

Duplicate “owner/repo” and wording is a bit long.

-      description: "Pin knowledge to specific repositories. Valid values: `null`: No pinning (default), `all`: Pin to all repositories, `owner/repo`: Pin to specific repository, `owner/repo`: Pin to specific repository",
+      description: "Pin knowledge to specific repositories. Valid values: `null` (no pinning, default), `all` (pin to all repos), or `owner/repo` (pin to a specific repo).",

---

95-106: Add sane defaults to HTTP client (timeout, baseURL, Accept)

Avoid indefinite hangs and rely on axios baseURL.

-      return axios($, {
-        url: `${this._baseUrl()}${path}`,
-        headers: {
-          ...headers,
-          Authorization: `Bearer ${this.$auth.api_key}`,
-        },
-        ...opts,
-      });
+      return axios($, {
+        baseURL: this._baseUrl(),
+        url: path,
+        timeout: 30000,
+        headers: {
+          Accept: "application/json",
+          ...headers,
+          Authorization: `Bearer ${this.$auth.api_key}`,
+        },
+        ...opts,
+      });

---

149-155: Add download attachments helper to cover requested endpoints

Issue #18250 includes “GET: Download attachment files.” Add a wrapper for completeness.

// Inside methods: { ... }
downloadAttachment({
  attachmentId, responseType = "arraybuffer", ...opts
}) {
  return this._makeRequest({
    path: `/attachments/${attachmentId}`,
    responseType,
    ...opts,
  });
}

components/devin/actions/list-knowledge/list-knowledge.mjs (1)

3-20: Support pagination inputs (limit/offset) to handle large result sets

Optional props keep backward compatibility and help users page through knowledge.

 export default {
   key: "devin-list-knowledge",
   name: "List Knowledge",
   description: "Retrieve a list of all knowledge objects. [See the documentation](https://docs.devin.ai/api-reference/knowledge/list-knowledge)",
   version: "0.0.1",
   type: "action",
   props: {
     devin,
+    limit: {
+      type: "integer",
+      label: "Limit",
+      description: "Max number of items to return",
+      optional: true,
+      default: 100,
+    },
+    offset: {
+      type: "integer",
+      label: "Offset",
+      description: "Number of items to skip before starting to collect the result set",
+      optional: true,
+      default: 0,
+    },
   },
   async run({ $ }) {
-    const response = await this.devin.listKnowledge({
-      $,
-    });
+    const response = await this.devin.listKnowledge({
+      $,
+      params: {
+        limit: this.limit,
+        offset: this.offset,
+      },
+    });
 
     $.export("$summary", `Successfully retrieved ${response.knowledge?.length || 0} knowledge objects`);
     return response;
   },
 };

If the endpoint returns a paginated container (e.g., next_offset, total), consider exporting pagination metadata in $summary.

components/devin/actions/get-session/get-session.mjs (1)

24-25: More robust summary fallback.

If the API doesn’t return title, include id before falling back to the input.

-    $.export("$summary", `Successfully retrieved session: ${response.title || this.sessionId}`);
+    $.export("$summary", `Successfully retrieved session: ${response.title ?? response.id ?? this.sessionId}`);

components/devin/actions/delete-knowledge/delete-knowledge.mjs (1)

18-26: Handle 204/empty responses gracefully.

Delete endpoints often return 204 No Content. Returning a fallback object improves UX.

     const response = await this.devin.deleteKnowledge({
       $,
       knowledgeId: this.knowledgeId,
     });
 
     $.export("$summary", `Successfully deleted knowledge object: ${this.knowledgeId}`);
-    return response;
+    return response ?? { success: true, knowledgeId: this.knowledgeId };

components/devin/actions/upload-file/upload-file.mjs (2)

19-34: Harden input and avoid forcing knownLength; allow large uploads.

• Enforce http(s) URL or /tmp path.
• Only set knownLength when size is finite.
• Allow large files via axios options.

   async run({ $ }) {
+    // Basic input hardening
+    if (!/^https?:\/\//i.test(this.filePathOrUrl) && !this.filePathOrUrl.startsWith("/tmp/")) {
+      throw new Error("filePathOrUrl must be an http(s) URL or a path under /tmp");
+    }
     const {
       stream, metadata,
     } = await getFileStreamAndMetadata(this.filePathOrUrl);
-    const form = new FormData();
-    form.append("file", stream, {
-      contentType: metadata.contentType,
-      knownLength: metadata.size,
-      filename: metadata.name,
-    });
+    const form = new FormData();
+    const appendOpts = {
+      filename: metadata.name,
+      contentType: metadata.contentType,
+    };
+    if (Number.isFinite(metadata.size)) {
+      appendOpts.knownLength = metadata.size;
+    }
+    form.append("file", stream, appendOpts);
 
     const response = await this.devin.uploadFile({
       $,
       headers: form.getHeaders(),
-      data: form,
+      data: form,
+      // Allow large uploads
+      maxBodyLength: Infinity,
+      maxContentLength: Infinity,
     });

---

5-11: Confirm coverage for “Download attachment files.”

Issue #18250 requires a download attachments endpoint. I don’t see a corresponding action in this PR.

Want me to add a “Download Attachment” action (accepting attachmentId, streaming to /tmp, and returning local path)?

components/devin/actions/update-session-tags/update-session-tags.mjs (2)

32-33: Include tag count in summary for quick feedback.

-    $.export("$summary", `Successfully updated tags for session ${this.sessionId}`);
+    $.export("$summary", `Successfully updated tags for session ${this.sessionId} (${this.tags?.length ?? 0} tags)`);

---

17-21: Replacing tags vs. merging — confirm intent.

This overwrites existing tags. If clearing or accidental empty arrays are not desired, consider a merge mode or a guard.

components/devin/actions/send-message-to-session/send-message-to-session.mjs (1)

23-26: Guard against empty messages.

   async run({ $ }) {
+    if (!this.message?.trim()) {
+      throw new Error("Message cannot be empty");
+    }
     const response = await this.devin.sendMessageToSession({
       $,
       sessionId: this.sessionId,

components/devin/actions/create-session/create-session.mjs (2)

47-56: Verify multi-select propDefinition for knowledge IDs.

You reference propDefinition "knowledgeId" while declaring type "string[]". Ensure the underlying devin prop supports multi-select, or expose a dedicated "knowledgeIds" propDefinition.

---

66-67: Avoid Pythonism in user-facing text.

-      description: "Custom title for the session. If None, a title will be generated automatically",
+      description: "Custom title for the session. If not provided, a title will be generated automatically",

components/devin/actions/list-sessions/list-sessions.mjs (2)

6-6: Description nit: remove “all” to avoid implying auto-pagination.

-  description: "Retrieve a list of all sessions. [See the documentation](https://docs.devin.ai/api-reference/sessions/list-sessions)",
+  description: "Retrieve a list of sessions. [See the documentation](https://docs.devin.ai/api-reference/sessions/list-sessions)",

---

42-43: Make summary resilient to varying response shapes.

-    $.export("$summary", `Successfully retrieved ${response.sessions?.length || 0} sessions`);
+    const count = Array.isArray(response.sessions)
+      ? response.sessions.length
+      : (response.results?.length ?? response.data?.length ?? 0);
+    $.export("$summary", `Successfully retrieved ${count} sessions`);

components/devin/actions/update-knowledge/update-knowledge.mjs (2)

43-45: Fix prop description to reflect update, not create

Minor copy edit for clarity.

-      description: "The ID of the folder to create the knowledge in",
+      description: "The ID of the parent folder for this knowledge object",

---

63-73: Optional: Send only fields the user provided if the API supports partial updates

Avoids an extra read and reduces payload surface. If Devin’s API accepts partial updates, build data from provided props only and skip the pre-fetch.

If supported, you could do:

const data = {};
if (typeof this.body !== "undefined") data.body = this.body;
if (typeof this.name !== "undefined") data.name = this.name;
if (typeof this.triggerDescription !== "undefined") data.trigger_description = this.triggerDescription;
if (typeof this.parentFolderId !== "undefined") data.parent_folder_id = this.parentFolderId;
if (typeof this.pinnedRepo !== "undefined") data.pinned_repo = this.pinnedRepo;

const response = await this.devin.updateKnowledge({ $, knowledgeId: this.knowledgeId, data });

Please confirm via docs or devin.app.mjs whether PUT supports partial updates or if a full resource is required.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.

components/devin/actions/update-knowledge/update-knowledge.mjs (3)

56-59: Account for pagination or use a get-by-id endpoint.

Listing once may miss the target item if paginated. Prefer a dedicated retrieval endpoint if available.

#!/bin/bash
# Inspect wrappers to confirm pagination + any get-by-id method
rg -nC3 'listKnowledge\\s*\\(' components/devin/devin.app.mjs
rg -nC2 -e 'cursor|page|limit|next|offset' components/devin/devin.app.mjs
rg -nC3 -e 'getKnowledge\\s*\\(|retrieveKnowledge\\s*\\(' components/devin/devin.app.mjs
# Check return shape for `knowledge` vs `items`
rg -nC2 '\\bknowledge\\b|\\bitems\\b' components/devin/devin.app.mjs | head -n 50

---

60-61: Guard when the knowledge item isn’t found.

Avoid dereferencing current if not found.

-    const current = knowledge.find(({ id }) => id === this.knowledgeId);
+    const current = knowledge.find(({ id }) => id === this.knowledgeId);
+    if (!current) {
+      throw new Error(`Knowledge item not found for id: ${this.knowledgeId}`);
+    }

---

66-71: Preserve intentional falsy updates; avoid || in merges.

Use undefined checks so empty string/false/null can overwrite existing values.

-        body: this.body || current.body,
-        name: this.name || current.name,
-        trigger_description: this.triggerDescription || current.trigger_description,
-        parent_folder_id: this.parentFolderId || current.parent_folder_id,
-        pinned_repo: this.pinnedRepo || current.pinned_repo,
+        body: typeof this.body !== "undefined" ? this.body : current.body,
+        name: typeof this.name !== "undefined" ? this.name : current.name,
+        trigger_description: typeof this.triggerDescription !== "undefined" ? this.triggerDescription : current.trigger_description,
+        parent_folder_id: typeof this.parentFolderId !== "undefined" ? this.parentFolderId : current.parent_folder_id,
+        pinned_repo: typeof this.pinnedRepo !== "undefined" ? this.pinnedRepo : current.pinned_repo,

components/devin/actions/update-knowledge/update-knowledge.mjs (2)

55-59: Require at least one updatable field.

Fail fast if no fields are provided.

   async run({ $ }) {
+    if (
+      typeof this.body === "undefined" &&
+      typeof this.name === "undefined" &&
+      typeof this.triggerDescription === "undefined" &&
+      typeof this.parentFolderId === "undefined" &&
+      typeof this.pinnedRepo === "undefined"
+    ) {
+      throw new Error("No fields to update: provide at least one of body, name, triggerDescription, parentFolderId, or pinnedRepo.");
+    }

---

74-74: Make the summary more informative.

Include the name when available.

-    $.export("$summary", `Successfully updated knowledge object: ${this.knowledgeId}`);
+    $.export("$summary", `Successfully updated knowledge: ${current?.name ?? this.knowledgeId}`);

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

components/devin/devin.app.mjs (2)

145-146: Use correct Send Message path: /session/{id}/message (not plural)

Per docs, the send message endpoint is singular. Update to avoid 404s. (docs.devin.ai)

-        path: `/sessions/${sessionId}/message`,
+        path: `/session/${sessionId}/message`,

---

111-113: Fix Get Session path: singular /session/{id}

Docs specify GET /session/{session_id}, not /sessions/{id}. Current path will 404. (docs.devin.ai)

-        path: `/sessions/${sessionId}`,
+        path: `/session/${sessionId}`,

components/devin/actions/list-sessions/list-sessions.mjs (2)

33-39: Pass tags as query params to leverage server-side filtering and avoid pagination misses

The API supports a tags query param; sending it reduces payloads and prevents missing matches beyond the current page. Keep the client-side filter as a defensive fallback. (docs.devin.ai)

-    const response = await this.devin.listSessions({
-      $,
-      params: {
-        limit: this.limit,
-        offset: this.offset,
-      },
-    });
+    const response = await this.devin.listSessions({
+      $,
+      params: {
+        limit: this.limit,
+        offset: this.offset,
+        ...(this.tags?.length ? { tags: this.tags } : {}),
+      },
+    });

---

17-30: Constrain limit/offset to documented ranges

Adds basic validation in the UI to match API: 1 <= limit <= 1000, offset >= 0. (docs.devin.ai)

     limit: {
       type: "integer",
       label: "Limit",
       description: "Maximum number of sessions to retrieve",
       optional: true,
       default: 100,
+      min: 1,
+      max: 1000,
     },
     offset: {
       type: "integer",
       label: "Offset",
       description: "Number of sessions to skip",
       optional: true,
       default: 0,
+      min: 0,
     },

components/devin/devin.app.mjs (2)

19-24: Add a fallback label for sessions without a title

Some sessions may have a null/empty title. Use session_id as a fallback to keep the dropdown usable. (docs.devin.ai)

-        return sessions?.map(({
-          session_id: value, title: label,
-        }) => ({
-          label,
-          value,
-        })) || [];
+        return sessions?.map(({
+          session_id: value, title,
+        }) => ({
+          label: title || value,
+          value,
+        })) || [];

---

85-89: Tighten pinnedRepo description to remove duplication

Minor copy tweak for clarity.

-      description: "Pin knowledge to specific repositories. Valid values: `null`: No pinning (default), `all`: Pin to all repositories, `owner/repo`: Pin to specific repository, `owner/repo`: Pin to specific repository",
+      description: "Pin knowledge to repositories. Valid values: `null` (no pinning, default), `all` (pin to all), or `owner/repo` (pin to a specific repo).",

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro