Skip to content

Fireflies - fix function call #18326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2025
Merged

Fireflies - fix function call #18326

merged 1 commit into from
Sep 9, 2025

Conversation

@andrewjschuang
Copy link
Contributor

@andrewjschuang andrewjschuang commented Sep 9, 2025 •
edited by coderabbitai bot
Loading

WHY

Summary by CodeRabbit

  • Bug Fixes

    • Corrected the default “last date” handling for new meeting detection, improving reliability of capturing meetings from the past day.

  • Chores

    • Bumped Fireflies component version to 0.1.3.

@vercel
Copy link

vercel bot commented Sep 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Sep 9, 2025 8:21pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Sep 9, 2025 8:21pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 9, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Updates Fireflies component version and adjusts the new-meeting-created source: increments its version and fixes default lastDate retrieval to call oneDayAgo() instead of referencing the function.

Changes

Cohort / File(s) Summary
Package Version Bump
components/fireflies/package.json		 Bump package version from 0.1.2 to 0.1.3.
New Meeting Source Fix
components/fireflies/sources/new-meeting-created/new-meeting-created.mjs		 Update exported source version 0.0.2 → 0.0.3; fix _getLastDate() to use this.oneDayAgo() when no stored lastDate.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant T as Trigger (New Meeting Created)
  participant S as Source Module
  participant DB as Local DB
  participant API as Fireflies API
  participant E as Emitter

  T->>S: Run poll
  S->>DB: get("lastDate")
  alt lastDate exists
    DB-->>S: lastDate
  else
    Note over S: Compute default lastDate via oneDayAgo()
    S-->>S: lastDate = oneDayAgo()
  end
  S->>API: fetch meetings since lastDate
  API-->>S: meetings[]
  S->>E: emit new meetings
  S->>DB: set("lastDate", now)
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A hop, a skip, a version three,
I nudge the date from branch to tree.
One day ago? I’ll call, not stare—
Functions hop when called with care.
Meetings bloom like clover bright,
Patch applied, all squeaky-light. 🐇✨

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db457a5 and d198db2.

📒 Files selected for processing (2)
  • components/fireflies/package.json (1 hunks)
  • components/fireflies/sources/new-meeting-created/new-meeting-created.mjs (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fireflies-fix-typo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@andrewjschuang andrewjschuang merged commit 0a27473 into master Sep 9, 2025
9 of 10 checks passed
@andrewjschuang andrewjschuang deleted the fireflies-fix-typo branch September 9, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewjschuang