Draft - PS-1039 - Mapbox attribution displayed #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edupazpix4d
requested review from
viktor-kopp-pix4d and
aleksandr-levin-pix4d
edupazpix4d
commented
Oct 27, 2021
|
|
||
| CustomGeoTiledMap::CustomGeoTiledMap(GeoTiledMappingManagerEngine *engine, QObject *parent) : | ||
| QGeoTiledMap(engine, parent) { | ||
| setCopyrightVisible(true); |
There was a problem hiding this comment.
This might be something you don't want to display if you use custom_urls, right? @viktor-kopp-pix4d @aleksandr-levin-pix4d
There was a problem hiding this comment.
yep, for custom tile providers it does not make sense to show Mapbox's logo
edupazpix4d
force-pushed
the
ps-1039-enable-mapbox-attribution
branch
from
f278bf4 to
93cd442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Mapbox copyright attribution, following the same approach done by default Qt MapboxGL plugin.
https://docs.mapbox.com/help/getting-started/attribution/