-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
Hi Team, and especially Klaus,
I have just pushed a complete revision of Klaus' INDIClient module: 48e3476, where we have a new, fully operational INDIMount process. In first place, congratulations to Klaus for his excellent work. The main changes with respect to Klaus' latest pull request #28 are:
- Redesigned INDINewPropertyItem class with more flexible template constructors.
- New template member functions INDIClient::SendNewPropertyItem() and INDIClient::MaybeSendNewPropertyItem() for simplified sending of device properties, including bulk properties.
- Extensive use of new PCL resources for sexagesimal numeric conversion and representation. See String::SexagesimalToDouble(), String::TrySexagesimalToDouble(), String::ParseSexagesimal(), String::TryParseSexagesimal() and String::ToSexagesimal() member functions (and their IsoString counterparts) in pcl/String.h and pcl/String.cpp. See also the new DecimalToSexagesimal() and SexagesimalToDecimal() global functions in pcl/Math.h.
- Redesigned CoordinateSearchDialog class with more powerful online search and interactive information visualization capabilities.
- Redesigned INDIMountInterface class.
- Improved AbstractINDIMountExecution (and derived classes) for better GUI interaction.
- Changed class member and enumeration identifiers for coherence with PCL coding style guidelines.
- Changed exported parameter identifiers to be more coherent with existing JavaScript interfaces. Of course, I have updated the relevant test scripts accordingly.
- New IMCCommand::ParkDefault command to park the mount at the current park coordinates (TELESCOPE_PARK_POSITION property). The IMCCommand::Park command now parks at the p_targetRA and p_targetDec parameter values of INDIMountInstance.
- Bug fixes and performance improvements.
I have tested this version and it seems to work extremely well. It passes all tests without any problems. There are a couple of very minor issues I'm going to fix, but it is ready for release IMO. Let me know if you agree with the changes.
Metadata
Metadata
Assignees
Labels
No labels