HgiVulkan: Incorrect Surface Check

The current code only checks if the base surface extension is available,
but doesn't check if the platform specific surface extension is
available. Resulting in the `_hasPresentation` to be set in cases where it
shouldn't.

Detected when trying to render via SSH using Vulkan.
See https://projects.blender.org/blender/blender/issues/149631 for
information.

Author: jeroenbakker-atmind

pxr/imaging/hgiVulkan/instance.cpp

@@ -101,21 +101,26 @@ HgiVulkanInstance::HgiVulkanInstance()
     VkInstanceCreateInfo createInfo = {VK_STRUCTURE_TYPE_INSTANCE_CREATE_INFO};
     createInfo.pApplicationInfo = &appInfo;
 
+    const char * surfaceExtensionName = nullptr;
+    // Pick platform specific surface extension
+    #if defined(VK_USE_PLATFORM_WIN32_KHR)
+        surfaceExtensionName = VK_KHR_WIN32_SURFACE_EXTENSION_NAME;
+    #elif defined(VK_USE_PLATFORM_XLIB_KHR)
+        surfaceExtensionName = VK_KHR_XLIB_SURFACE_EXTENSION_NAME;
+    #elif defined(VK_USE_PLATFORM_METAL_EXT)
+        surfaceExtensionName = VK_EXT_METAL_SURFACE_EXTENSION_NAME;
+    #else
+        #error Unsupported Platform
+    #endif
+
     // Setup instance extensions.
     std::vector<const char*> extensions = {
         VK_KHR_SURFACE_EXTENSION_NAME,
-
-        // Pick platform specific surface extension
-        #if defined(VK_USE_PLATFORM_WIN32_KHR)
-            VK_KHR_WIN32_SURFACE_EXTENSION_NAME,
-        #elif defined(VK_USE_PLATFORM_XLIB_KHR)
-            VK_KHR_XLIB_SURFACE_EXTENSION_NAME,
-        #elif defined(VK_USE_PLATFORM_METAL_EXT)
-            VK_EXT_METAL_SURFACE_EXTENSION_NAME,
+        surfaceExtensionName,
+        
+        #if defined(VK_USE_PLATFORM_METAL_EXT)
             // See: https://github.com/KhronosGroup/MoltenVK/blob/main/Docs/MoltenVK_Runtime_UserGuide.md#interacting-with-the-moltenvk-runtime
             VK_KHR_PORTABILITY_ENUMERATION_EXTENSION_NAME,
-        #else
-            #error Unsupported Platform
         #endif
 
         // Extensions for interop with OpenGL
@@ -151,8 +156,8 @@ HgiVulkanInstance::HgiVulkanInstance()
     extensions = _RemoveUnsupportedInstanceExtensions(extensions);
 
     _hasPresentation = std::any_of(extensions.begin(), extensions.end(),
-        [](const char* extensionName) {
-            return strcmp(extensionName, VK_KHR_SURFACE_EXTENSION_NAME) == 0;
+        [&](const char* extensionName) {
+            return strcmp(extensionName, surfaceExtensionName) == 0;
         });
 
     createInfo.ppEnabledLayerNames = layers.data();