Fixes, supresses a few warnings

Author: arpadbarta

LiteDB.Tests/Internals/Aes_Tests.cs

@@ -41,23 +41,23 @@ public void Encrypt_Decrypt_Stream()
 
                 // read encrypted data
                 media.Position = 0;
-                media.Read(output0, 0, 8192);
-                media.Read(output1, 0, 8192);
-                media.Read(output2, 0, 8192);
+                media.ReadExactly(output0, 0, 8192);
+                media.ReadExactly(output1, 0, 8192);
+                media.ReadExactly(output2, 0, 8192);
 
                 output0.All(x => x == 100).Should().BeFalse();
                 output1.All(x => x == 101).Should().BeFalse();
                 output2.All(x => x == 102).Should().BeFalse();
 
                 // read decrypted data
                 crypto.Position = 0 * 8192;
-                crypto.Read(output0, 0, 8192);
+                crypto.ReadExactly(output0, 0, 8192);
 
                 crypto.Position = 2 * 8192;
-                crypto.Read(output2, 0, 8192);
+                crypto.ReadExactly(output2, 0, 8192);
 
                 crypto.Position = 1 * 8192;
-                crypto.Read(output1, 0, 8192);
+                crypto.ReadExactly(output1, 0, 8192);
 
                 output0.All(x => x == 100).Should().BeTrue();
                 output1.All(x => x == 101).Should().BeTrue();
@@ -137,7 +137,7 @@ public void AesStream_Invalid_Password()
                         .GetValue(crypto) as CryptoStream;
 
                     memoryStream.Position = 32;
-                    cryptoReader.Read(checkBytes, 0, checkBytes.Length);
+                    cryptoReader.ReadExactly(checkBytes, 0, checkBytes.Length);
                     Assert.All(checkBytes, b => Assert.Equal(1, b));
                 }
             }

LiteDB.Tests/Internals/CacheAsync_Tests.cs

@@ -11,7 +11,7 @@ namespace LiteDB.Internals
     public class CacheAsync_Tests
     {
         [Fact]
-        public void CacheAsync_Thread_ShareCounter()
+        public async Task CacheAsync_Thread_ShareCounterAsync()
         {
             // Set()   - Seta true - Se estiver bloqueado, vai liberar
             // Reset() - Seta false - Quando chegar no proximo Wait() vai aguardar
@@ -83,7 +83,7 @@ void serialize(ManualResetEventSlim toBlock, ManualResetEventSlim toFree)
             ta.Start();
             tb.Start();
 
-            Task.WaitAll(ta, tb);
+            await Task.WhenAll(ta, tb);
         }
     }
 }

LiteDB.Tests/Issues/Issue2265_Tests.cs

@@ -34,7 +34,7 @@ public void Test()
         using (var db = new LiteDatabase(":memory:"))
         {
             var c = db.GetCollection<Weights>("weights");
-            Weights? w = c.FindOne(x => true);
+            Weights w = c.FindOne(x => true);
             if (w == null)
             {
                 w = new Weights();

LiteDB/Document/DataReader/BsonDataReader.cs

@@ -108,7 +108,7 @@ public bool Read()
                     catch (Exception ex)
                     {
                         _state.Handle(ex);
-                        throw ex;
+                        throw;
                     }
                 }
                 else

LiteDB/Engine/Disk/Streams/AesStream.cs

@@ -90,7 +90,9 @@ public AesStream(string password, Stream stream)
                 _aes.Padding = PaddingMode.None;
                 _aes.Mode = CipherMode.ECB;
 
+#pragma warning disable SYSLIB0041
                 var pdb = new Rfc2898DeriveBytes(password, this.Salt);
+#pragma warning restore SYSLIB0041
 
                 using (pdb as IDisposable)
                 {

LiteDB/Engine/FileReader/Legacy/AesEncryption.cs

@@ -18,7 +18,9 @@ public AesEncryption(string password, byte[] salt)
             _aes = Aes.Create();
             _aes.Padding = PaddingMode.Zeros;
 
+#pragma warning disable SYSLIB0041
             var pdb = new Rfc2898DeriveBytes(password, salt);
+#pragma warning restore SYSLIB0041
 
             using (pdb as IDisposable)
             {

LiteDB/Engine/Query/QueryExecutor.cs

@@ -136,7 +136,7 @@ IEnumerable<BsonDocument> RunQuery()
                     catch (Exception ex)
                     {
                         _state.Handle(ex);
-                        throw ex;
+                        throw;
                     }
 
                     while (read)
@@ -157,7 +157,7 @@ IEnumerable<BsonDocument> RunQuery()
                         catch (Exception ex)
                         {
                             _state.Handle(ex);
-                            throw ex;
+                            throw;
                         }
                     }
                 }