Skip to content

Commit 2306518

Browse files
committed
fixup! fixup! fixup! feat: adding settings capabilities
1 parent c0c97ee commit 2306518

File tree

3 files changed

+19
-3
lines changed

3 files changed

+19
-3
lines changed

example/app/settings.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ export default function settings() {
121121
<Button
122122
onPress={async () => {
123123
try {
124+
setSettingError(null);
125+
124126
const valueB64 = await readSetting(selectedDeviceId, settingName);
125127
const decodedValue = Buffer.from(valueB64, 'base64').toString(
126128
'binary'
@@ -142,6 +144,8 @@ export default function settings() {
142144
<Button
143145
onPress={async () => {
144146
try {
147+
setSettingError(null);
148+
145149
const encodedValue = Buffer.from(settingValue, 'binary').toString(
146150
'base64'
147151
);

example/src/useBluetoothDevices.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const useBluetoothDevices = () => {
1515
BLEService.initializeBLE().then(() =>
1616
bleManager.startDeviceScan(
1717
[],
18-
{ allowDuplicates: false },
18+
{ allowDuplicates: false, legacyScan: false },
1919
(e, scannedDevice) => {
2020
if (e) {
2121
setError(`${e.message} - ${e.reason}`);

react-native-mcu-manager/ios/ReactNativeMcuManagerModule.swift

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,15 @@ public class ReactNativeMcuManagerModule: Module {
112112
return
113113
}
114114

115-
let data = response?.val?.data(using: .utf8)
115+
let smpErr = response?.getError()
116+
if (smpErr != nil) {
117+
promise.reject(Exception(name: "ReadSettingError", description: smpErr!.localizedDescription))
118+
return
119+
}
120+
121+
let data = response?.val?.data(using: .utf8) ?? Data()
116122

117-
promise.resolve(data?.base64EncodedString())
123+
promise.resolve(data.base64EncodedString())
118124
}
119125
}
120126

@@ -142,6 +148,12 @@ public class ReactNativeMcuManagerModule: Module {
142148
return
143149
}
144150

151+
let smpErr = response?.getError()
152+
if (smpErr != nil) {
153+
promise.reject(Exception(name: "WriteSettingError", description: smpErr!.localizedDescription))
154+
return
155+
}
156+
145157
promise.resolve()
146158
}
147159
}

0 commit comments

Comments
 (0)