Skip to content

Commit 928d117

Browse files
committed
fix(events): Remove all events
These are no longer wired up correctly
1 parent 3619ec5 commit 928d117

File tree

3 files changed

+0
-61
lines changed

3 files changed

+0
-61
lines changed

example/src/useFirmwareUpdate.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,7 @@ const useFirmwareUpdate = (
2828

2929
upgradeRef.current = upgrade;
3030

31-
const uploadProgressListener = upgrade.addListener(
32-
'uploadProgress',
33-
({ progress: newProgress }) => {
34-
setProgress(newProgress);
35-
}
36-
);
37-
38-
const uploadStateChangedListener = upgrade.addListener(
39-
'upgradeStateChanged',
40-
({ state: newState }) => {
41-
setState(newState);
42-
}
43-
);
44-
4531
return function cleanup() {
46-
uploadProgressListener.remove();
47-
uploadStateChangedListener.remove();
48-
4932
upgrade.cancel();
5033
upgrade.destroy();
5134
};

react-native-mcu-manager/ios/ReactNativeMcuManagerModule.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,13 @@ import os
55

66
private let MODULE_NAME = "ReactNativeMcuManager"
77
private let TAG = "McuManagerModule"
8-
private let UPGRADE_STATE_EVENTS = "upgradeStateChanged"
9-
private let UPLOAD_PROGRESS_EVENTS = "uploadProgress"
108

119
public class ReactNativeMcuManagerModule: Module {
1210
private var upgrades: [String: DeviceUpgrade] = [:]
1311

1412
public func definition() -> ModuleDefinition {
1513
Name(MODULE_NAME)
1614

17-
// Defines event names that the module can send to JavaScript.
18-
Events(UPGRADE_STATE_EVENTS, UPLOAD_PROGRESS_EVENTS)
19-
2015
AsyncFunction("eraseImage") { (bleId: String, promise: Promise) in
2116
guard let bleUuid = UUID(uuidString: bleId) else {
2217
promise.reject(Exception(name: "UUIDParseError", description: "Failed to parse UUID"))

react-native-mcu-manager/src/Upgrade.ts

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { EventEmitter, EventSubscription } from 'expo-modules-core';
2-
31
import ReactNativeMcuManager from './ReactNativeMcuManagerModule';
42

53
export enum UpgradeMode {
@@ -50,33 +48,6 @@ export type FirmwareUpgradeState =
5048
declare const UpgradeIdSymbol: unique symbol;
5149
type UpgradeID = string & { [UpgradeIdSymbol]: never };
5250

53-
type UpgradeEvent = 'upgradeStateChanged' | 'uploadProgress';
54-
55-
type UpgradeStateChangedPayload = {
56-
id: UpgradeID;
57-
state: FirmwareUpgradeState;
58-
};
59-
type UploadProgressPayload = { id: UpgradeID; progress: number };
60-
type UpgradeEventPayload = UpgradeStateChangedPayload & UploadProgressPayload;
61-
62-
type AddUpgradeListener = {
63-
(
64-
eventType: 'upgradeStateChanged',
65-
listener: (event: UpgradeStateChangedPayload) => void
66-
): EventSubscription;
67-
(
68-
eventType: 'uploadProgress',
69-
listener: (event: UploadProgressPayload) => void
70-
): EventSubscription;
71-
};
72-
73-
type McuManagerEventMap = {
74-
upgradeStateChanged: (payload: UpgradeStateChangedPayload) => void;
75-
uploadProgress: (payload: UploadProgressPayload) => void;
76-
};
77-
78-
const McuManagerEvents = new EventEmitter<McuManagerEventMap>();
79-
8051
class Upgrade {
8152
private id: UpgradeID;
8253

@@ -122,16 +93,6 @@ class Upgrade {
12293
ReactNativeMcuManager.cancelUpgrade(this.id);
12394
};
12495

125-
addListener: AddUpgradeListener = (
126-
eventType: UpgradeEvent,
127-
listener: (event: UpgradeEventPayload) => void
128-
): EventSubscription => {
129-
return McuManagerEvents.addListener(eventType, (event) => {
130-
if (event.id !== this.id) return;
131-
listener(event);
132-
});
133-
};
134-
13596
/**
13697
* Call to release native Upgrade class.
13798
* Failure to do so may result in memory leaks.

0 commit comments

Comments
 (0)