Is it worthwhile spending time making checks for false conditions more consistent?

[AaronLi]

While looking through the code for drawing.cpp, I noticed that false conditions were checked 3 different ways in a window of 10 lines.

NightDriverStrip/src/drawing.cpp

Lines 172 to 182 in 3a05a9b

	if (false == g_apBufferManager[iChannel]->IsEmpty())
	{
	shared_ptr<LEDBuffer> pBuffer;
	if (NTPTimeClient::HasClockBeenSet() == false)
	{
	pBuffer = g_apBufferManager[iChannel]->GetOldestBuffer();
	}
	else
	{
	// Chew through ALL frames older than now, ignoring them
	while (!g_apBufferManager[iChannel]->IsEmpty() && g_apBufferManager[iChannel]->PeekOldestBuffer()->IsBufferOlderThan(tv))

We have false == ..., ... == false, and !... all in one file. Does it make sense to spend time changing these to all one style such as using only ! ?

Also see: egrep "([\w\W]+?( ?== ?false))|((false ?== ?)[\w\W]+?)" -Hrn

[rbergen]

I would say it isn't worthwhile to apply consistency as a thing in itself. Restructuring Boolean logic requires extremely careful review, during which it's still easy to overlook unintended changes to the logic in question. As the modifications to the code should not lead to any change in behavior, I think the changes wouldn't do well on the "BlinkenPerBit" scale.

If there is a reason to modify the code containing the logic for other reasons - or add new logic to it - then I would be supportive of applying a (more) consistent coding style.