Replies: 1 comment 1 reply
-
For minor edits like this, click the 'edit' button in the upper right
corner of the frame with the file data (the icon is a pencil) on the page
with the source, e.g.:
https://github.com/PlummersSoftwareLLC/NightDriverStrip/blob/main/src/main.cpp
I'm going to turn this around and assign homework (it's good for you :-)
back to you. Please make your own plus a few other super-minord typos in
that block:
// In addition to simple trips, the app handles matrixes as well.
// In addition to simple *s*trips, the app handles matrixes as well.
(wrong word)
// web server built in that serves a sample jqueryUI based UI
// web server built in that serves a sample j*Q*ueryUI*-*based UI (cap +
missing hyphenation)
// The app controls WS2812B style LEDs. The number of LEDs in a
// The app controls WS2812B-style LEDs. The number of LEDs in a (same)
// Setup sets pin directions, starts wifi, initialized the LEDs, etc.
// Setup sets pin directions, starts wifi, initialize*s* the LEDs, etc.
(keep verb tense separate)
// A number of worker threads are created which:
// A number of worker threads are created*,* which: ( add comma)
// 5) Listen to room audio, create a spectrum, look for beat
to
// 5) Listen to room audio, create a spectrum, *and* look for *a* beat
t that I don't care, there's just no
t that I don't care*;* there's just no (it's a semicolon)
In timely news, this header contains the story of the FANS nomenclature...
If you could edit those, please, and make a pull request, it'll get
reviewed by Rutger and applied eventually. Super low impact stuff like this
shouldn't be too big of a deal, I'd hope. It's possible he'll batch it with
something else before submitting it, though.
Yes, I'm trying to get you confidence and practice in this sort of thing.
;-)
Thanx,
RJL
… Message ID: <PlummersSoftwareLLC/NightDriverStrip/repo-discussions/683@
github.com>
|
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Actually, now I've found another typo in README.md mentioned at the end of this post.
This is truly a minor thing but... in the fourth paragraph of "Description"
it reads:
// By default, NightDriver draws client effects, and there many
// built in, from marquees to fire.
Shouldn't it read...
// By default, NightDriver draws client effects, and there are
// many built in, from marquees to fire.
And I just found another typo in the README.md on line #321 which currently reads:
"This repository includes a number of scrips to perform various tasks during or after building projects."
This should be "scripts".
Beta Was this translation helpful? Give feedback.
All reactions