Remove binaries from source and put in a release instead.

[KianGentry]

Binaries should be put within a designated release, i.e. Retropad 1.0 on GitHub Releases.

Including binaries in source is generally bad practice; it can quickly bloat the download size of the source and, as you said in the video, could be a security risk to some.

[brdjns]

I wouldn't put them in releases either. If the source is available, users should compile it themselves.

[KianGentry]

Users should compile it themselves.

Agreed, however small projects like these usually include precompiled binaries in a release. Makes it easier for casual PC users to just download the EXE and use it.

[jadedzilla]

Additionally, users who would prefer to compile it themselves (like myself) likely do not want to pull the exe file to their systems along with the source.

[Pontiac76]

Are we really going to complain about a 150kb binary file?

There's perks to having this small EXE available. First, it's revisioned. Second, lazy people (Like myself) can do enough work to do the pull or just download the EXE right from Github and execute (Bad practice, I understand). Third, if you want to do a binary compare and attempt to figure out why your make ends up making a 3gig file instead of a less than 200k file, you've got some additional analysis to do on your setup. Having the EXE gives you the opportunity to evaluate differences from the get-go at a byte for byte comparison.

Sure, docs could be kept up to indicate what the expectations are, but having a phrase to say "The resultant executable should be 150kb" doesn't give enough detail to WHY the delta in size differences.

For "releases", sure, when code is going to be changing frequently, I could see revisions being thrown up. But this is a one-off project that I doubt is going to be recompiled and have any real PRs put against it. After all, AI made this... Should be perfect as is. ... right?

So yeah, maybe bad-practice on Daves part to not make revisions. But also measure the effort to do all that work. Dave has other things to do rather than appease standards for mega corps that do things a billion different ways to their own billion different standards of distribution, so I'm on board with his methodology.

[KianGentry]

Are we really going to complain about a 150kb binary file?

Yep, and you made all valid points still.

I just think it makes things neater while taking little effort (10 minutes maximum).

It's not a huge deal, but if Dave wants to look back at this project to tidy it up himself, then this is definitely something to consider.

[linuxgurugamer]

Having binaries in a repo can violate some org security settings. It really should be put into a release file