Incomplete responses show -999 on downloaded report OU 980876

Emanoil Manoylov · Emanoil Manoylov · commit 45705b654385 · 2026-03-09T11:30:41.000Z
diff --git a/classes/question/question.php b/classes/question/question.php
@@ -46,6 +46,7 @@
 define('QUESFILE', 12);
 define('QUESPAGEBREAK', 99);
 define('QUESSECTIONTEXT', 100);
+define('QUESRATEUNANSWERED', -999);
 
 global $idcounter, $CFG;
 $idcounter = 0;
diff --git a/classes/question/rate.php b/classes/question/rate.php
@@ -315,7 +315,8 @@ protected function question_survey_display($response, $descendantsdata, $blankqu
 
         $num = 0;
         foreach ($this->choices as $cid => $choice) {
-            $num += (isset($response->answers[$this->id][$cid]) && ($response->answers[$this->id][$cid]->value != -999));
+            $num += (isset($response->answers[$this->id][$cid]) &&
+                $response->answers[$this->id][$cid]->value != QUESRATEUNANSWERED);
         }
 
         $notcomplete = false;
@@ -361,13 +362,13 @@ protected function question_survey_display($response, $descendantsdata, $blankqu
                     $title = '';
                     if (
                         $notcomplete && isset($response->answers[$this->id][$cid]) &&
-                        ($response->answers[$this->id][$cid]->value == -999)
+                        $response->answers[$this->id][$cid]->value == QUESRATEUNANSWERED
                     ) {
                         $completeclass = 'notcompleted';
                         $title = get_string('pleasecomplete', 'questionnaire');
                     }
-                    // Set value of notanswered button to -999 in order to eliminate it from form submit later on.
-                    $colinput = ['name' => $str, 'value' => -999];
+                    // Set value of notanswered button in order to eliminate it from form submit later on.
+                    $colinput = ['name' => $str, 'value' => QUESRATEUNANSWERED];
                     if (!empty($checked)) {
                         $colinput['checked'] = true;
                     }
@@ -624,8 +625,8 @@ public function response_complete($responsedata) {
                 if (isset($answers[$cid]) && !empty($answers[$cid]) && ($answers[$cid]->value == $na)) {
                     $answers[$cid]->value = -1;
                 }
-                // If choice value == -999 this is a not yet answered choice.
-                $num += (isset($answers[$cid]) && ($answers[$cid]->value != -999));
+                // Ignore if value means this is a not yet answered choice.
+                $num += (isset($answers[$cid]) && $answers[$cid]->value != QUESRATEUNANSWERED);
             }
             $nbchoices -= $nameddegrees;
         }
@@ -675,8 +676,8 @@ public function response_valid($responsedata) {
                 if (isset($answers[$cid]) && ($answers[$cid]->value == $na)) {
                     $answers[$cid]->value = -1;
                 }
-                // If choice value == -999 this is a not yet answered choice.
-                $num += (isset($answers[$cid]) && ($answers[$cid]->value != -999));
+                // Ignore if value means this is a not yet answered choice.
+                $num += (isset($answers[$cid]) && $answers[$cid]->value != QUESRATEUNANSWERED);
             }
             $nbchoices -= $nameddegrees;
         }
diff --git a/questionnaire.class.php b/questionnaire.class.php
@@ -2450,7 +2450,8 @@ private function get_full_submission_for_export($rid) {
                             } else {
                                 $rating = $this->responses[$rid]->answers[$question->id][$cid]->value;
                             }
-                            $response->answers[] = $question->choices[$cid]->content . ' = ' . $rating;
+                            $response->answers[] = $question->choices[$cid]->content . ' = ' .
+                                ($rating != QUESRATEUNANSWERED ? $rating : '');
                         }
                     }
                 }
@@ -3473,7 +3474,8 @@ protected function process_csv_row(
 
         for ($c = $nbinfocols; $c < $numrespcols; $c++) {
             if (isset($row[$c])) {
-                $positioned[] = $row[$c];
+                // Ignore if value means this is a not yet answered choice.
+                $positioned[] = $row[$c] != QUESRATEUNANSWERED ? $row[$c] : null;
             } else if (isset($questionsbyposition[$c])) {
                 $question = $questionsbyposition[$c];
                 $qtype = intval($question->type_id);
diff --git a/tests/behat/behat_mod_questionnaire.php b/tests/behat/behat_mod_questionnaire.php
@@ -448,11 +448,11 @@ private function add_response_data($qid, $sid) {
             ["", "6", "13", "18", "-1"],
             ["", "6", "13", "19", "1"],
             ["", "6", "13", "20", "-1"],
-            ["", "7", "13", "16", "-999"],
-            ["", "7", "13", "17", "-999"],
-            ["", "7", "13", "18", "-999"],
-            ["", "7", "13", "19", "-999"],
-            ["", "7", "13", "20", "-999"],
+            ["", "7", "13", "16", QUESRATEUNANSWERED],
+            ["", "7", "13", "17", QUESRATEUNANSWERED],
+            ["", "7", "13", "18", QUESRATEUNANSWERED],
+            ["", "7", "13", "19", QUESRATEUNANSWERED],
+            ["", "7", "13", "20", QUESRATEUNANSWERED],
         ];
         $this->add_data(
             $responserank,
diff --git a/tests/csvexport_test.php b/tests/csvexport_test.php
@@ -76,17 +76,19 @@ public function test_csvexport(): void {
             $questionnaireinst = new \questionnaire($course, $cm, 0, $questionnaire);
 
             // Test for only complete responses.
+            $expectedoutput = $this->expected_complete_output();
             $newoutput = $this->get_csv_text($questionnaireinst->generate_csv(0, '', '', 0, 0, 0));
-            $this->assertEquals(count($newoutput), count($this->expected_complete_output()));
+            $this->assertEquals(count($newoutput), count($expectedoutput));
             foreach ($newoutput as $key => $output) {
-                $this->assertEquals($this->expected_complete_output()[$key], $output);
+                $this->assertEquals($expectedoutput[$key], $output, "Output #$key");
             }
 
             // Test for all responses.
+            $expectedoutput = $this->expected_incomplete_output();
             $newoutput = $this->get_csv_text($questionnaireinst->generate_csv(0, '', '', 0, 0, 1));
-            $this->assertEquals(count($newoutput), count($this->expected_incomplete_output()));
+            $this->assertEquals(count($newoutput), count($expectedoutput));
             foreach ($newoutput as $key => $output) {
-                $this->assertEquals($this->expected_incomplete_output()[$key], $output);
+                $this->assertEquals($expectedoutput[$key], $output, "Output #$key");
             }
         }
     }
@@ -243,6 +245,6 @@ private function expected_incomplete_output() {
             "		Test course 1			Testy Lastname4	username4	y	Test answer	Some header textSome paragraph text	83	" .
             "27/12/2017	wind	three	0	0	0	0	0	0	0	0	0	1	1	2	3	4	5	1	2	3	4		5",
             "		Test course 1			Testy Lastname5	username5	n	Test answer	Some header textSome paragraph text	83	" .
-            "27/12/2017	wind	three	0	0	0	0	0	0	0	0	0	1	1	2	3	4	5	1	2	3	4		5"];
+            "27/12/2017	wind	three	0	0	0	0	0	0	0	0	0	1											5"];
     }
 }
diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -661,7 +661,8 @@ public function generate_response($questionnaire, $questions, $userid, $complete
                 case QUESRATE:
                     $answers = [];
                     for ($a = 0; $a < count($choices) - 1; $a++) {
-                        $answers[] = new question_response_rank($choices[$a], (($a % 5) + 1));
+                        $rank = $complete ? (($a % 5) + 1) : QUESRATEUNANSWERED;
+                        $answers[] = new question_response_rank($choices[$a], $rank);
                     }
                     $responses[] = new question_response($question->id, $answers);
                     break;
diff --git a/tests/privacy_provider_test.php b/tests/privacy_provider_test.php
@@ -138,8 +138,8 @@ public function test_export_user_data(): void {
         $this->assertEquals('7. Numeric 1004', $data->responses[0]['questions'][7]->questionname);
         $this->assertEquals(83, $data->responses[0]['questions'][7]->answers[0]);
         $this->assertEquals('22. Rate Scale 1014', $data->responses[0]['questions'][22]->questionname);
-        $this->assertEquals('fourteen = 1', $data->responses[0]['questions'][22]->answers[0]);
-        $this->assertEquals('happy = 3', $data->responses[0]['questions'][22]->answers[7]);
+        $this->assertEquals('fourteen = ', $data->responses[0]['questions'][22]->answers[0]);
+        $this->assertEquals('happy = ', $data->responses[0]['questions'][22]->answers[7]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -315,7 +315,8 @@ protected function question_survey_display($response, $descendantsdata, $blankqu`
`315`	`315`
`316`	`316`	`$num = 0;`
`317`	`317`	`foreach ($this->choices as $cid => $choice) {`
`318`		`- $num += (isset($response->answers[$this->id][$cid]) && ($response->answers[$this->id][$cid]->value != -999));`
	`318`	`+ $num += (isset($response->answers[$this->id][$cid]) &&`
	`319`	`+ $response->answers[$this->id][$cid]->value != QUESRATEUNANSWERED);`
`319`	`320`	`}`
`320`	`321`
`321`	`322`	`$notcomplete = false;`
`@@ -361,13 +362,13 @@ protected function question_survey_display($response, $descendantsdata, $blankqu`
`361`	`362`	`$title = '';`
`362`	`363`	`if (`
`363`	`364`	`$notcomplete && isset($response->answers[$this->id][$cid]) &&`
`364`		`- ($response->answers[$this->id][$cid]->value == -999)`
	`365`	`+ $response->answers[$this->id][$cid]->value == QUESRATEUNANSWERED`
`365`	`366`	`) {`
`366`	`367`	`$completeclass = 'notcompleted';`
`367`	`368`	`$title = get_string('pleasecomplete', 'questionnaire');`
`368`	`369`	`}`
`369`		`- // Set value of notanswered button to -999 in order to eliminate it from form submit later on.`
`370`		`- $colinput = ['name' => $str, 'value' => -999];`
	`370`	`+ // Set value of notanswered button in order to eliminate it from form submit later on.`
	`371`	`+ $colinput = ['name' => $str, 'value' => QUESRATEUNANSWERED];`
`371`	`372`	`if (!empty($checked)) {`
`372`	`373`	`$colinput['checked'] = true;`
`373`	`374`	`}`
`@@ -624,8 +625,8 @@ public function response_complete($responsedata) {`
`624`	`625`	`if (isset($answers[$cid]) && !empty($answers[$cid]) && ($answers[$cid]->value == $na)) {`
`625`	`626`	`$answers[$cid]->value = -1;`
`626`	`627`	`}`
`627`		`- // If choice value == -999 this is a not yet answered choice.`
`628`		`- $num += (isset($answers[$cid]) && ($answers[$cid]->value != -999));`
	`628`	`+ // Ignore if value means this is a not yet answered choice.`
	`629`	`+ $num += (isset($answers[$cid]) && $answers[$cid]->value != QUESRATEUNANSWERED);`
`629`	`630`	`}`
`630`	`631`	`$nbchoices -= $nameddegrees;`
`631`	`632`	`}`
`@@ -675,8 +676,8 @@ public function response_valid($responsedata) {`
`675`	`676`	`if (isset($answers[$cid]) && ($answers[$cid]->value == $na)) {`
`676`	`677`	`$answers[$cid]->value = -1;`
`677`	`678`	`}`
`678`		`- // If choice value == -999 this is a not yet answered choice.`
`679`		`- $num += (isset($answers[$cid]) && ($answers[$cid]->value != -999));`
	`679`	`+ // Ignore if value means this is a not yet answered choice.`
	`680`	`+ $num += (isset($answers[$cid]) && $answers[$cid]->value != QUESRATEUNANSWERED);`
`680`	`681`	`}`
`681`	`682`	`$nbchoices -= $nameddegrees;`
`682`	`683`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2450,7 +2450,8 @@ private function get_full_submission_for_export($rid) {`
`2450`	`2450`	`} else {`
`2451`	`2451`	`$rating = $this->responses[$rid]->answers[$question->id][$cid]->value;`
`2452`	`2452`	`}`
`2453`		`- $response->answers[] = $question->choices[$cid]->content . ' = ' . $rating;`
	`2453`	`+ $response->answers[] = $question->choices[$cid]->content . ' = ' .`
	`2454`	`+ ($rating != QUESRATEUNANSWERED ? $rating : '');`
`2454`	`2455`	`}`
`2455`	`2456`	`}`
`2456`	`2457`	`}`
`@@ -3473,7 +3474,8 @@ protected function process_csv_row(`
`3473`	`3474`
`3474`	`3475`	`for ($c = $nbinfocols; $c < $numrespcols; $c++) {`
`3475`	`3476`	`if (isset($row[$c])) {`
`3476`		`- $positioned[] = $row[$c];`
	`3477`	`+ // Ignore if value means this is a not yet answered choice.`
	`3478`	`+ $positioned[] = $row[$c] != QUESRATEUNANSWERED ? $row[$c] : null;`
`3477`	`3479`	`} else if (isset($questionsbyposition[$c])) {`
`3478`	`3480`	`$question = $questionsbyposition[$c];`
`3479`	`3481`	`$qtype = intval($question->type_id);`
Original file line number	Diff line number	Diff line change
`@@ -76,17 +76,19 @@ public function test_csvexport(): void {`
`76`	`76`	`$questionnaireinst = new \questionnaire($course, $cm, 0, $questionnaire);`
`77`	`77`
`78`	`78`	`// Test for only complete responses.`
	`79`	`+ $expectedoutput = $this->expected_complete_output();`
`79`	`80`	`$newoutput = $this->get_csv_text($questionnaireinst->generate_csv(0, '', '', 0, 0, 0));`
`80`		`- $this->assertEquals(count($newoutput), count($this->expected_complete_output()));`
	`81`	`+ $this->assertEquals(count($newoutput), count($expectedoutput));`
`81`	`82`	`foreach ($newoutput as $key => $output) {`
`82`		`- $this->assertEquals($this->expected_complete_output()[$key], $output);`
	`83`	`+ $this->assertEquals($expectedoutput[$key], $output, "Output #$key");`
`83`	`84`	`}`
`84`	`85`
`85`	`86`	`// Test for all responses.`
	`87`	`+ $expectedoutput = $this->expected_incomplete_output();`
`86`	`88`	`$newoutput = $this->get_csv_text($questionnaireinst->generate_csv(0, '', '', 0, 0, 1));`
`87`		`- $this->assertEquals(count($newoutput), count($this->expected_incomplete_output()));`
	`89`	`+ $this->assertEquals(count($newoutput), count($expectedoutput));`
`88`	`90`	`foreach ($newoutput as $key => $output) {`
`89`		`- $this->assertEquals($this->expected_incomplete_output()[$key], $output);`
	`91`	`+ $this->assertEquals($expectedoutput[$key], $output, "Output #$key");`
`90`	`92`	`}`
`91`	`93`	`}`
`92`	`94`	`}`
`@@ -243,6 +245,6 @@ private function expected_incomplete_output() {`
`243`	`245`	`" Test course 1 Testy Lastname4 username4 y Test answer Some header textSome paragraph text 83 " .`
`244`	`246`	`"27/12/2017 wind three 0 0 0 0 0 0 0 0 0 1 1 2 3 4 5 1 2 3 4 5",`
`245`	`247`	`" Test course 1 Testy Lastname5 username5 n Test answer Some header textSome paragraph text 83 " .`
`246`		`- "27/12/2017 wind three 0 0 0 0 0 0 0 0 0 1 1 2 3 4 5 1 2 3 4 5"];`
	`248`	`+ "27/12/2017 wind three 0 0 0 0 0 0 0 0 0 1 5"];`
`247`	`249`	`}`
`248`	`250`	`}`