Phase 8 follow-up: delegate completion check through persistent layer

- Add response_record::user_has_complete_response() using record_exists_select()
- Add questionnaire::user_has_submitted() delegating to response_record
- Add questionnaire::completionsubmit() accessor
- Add manager::response_exists() instance method delegating to response_record
- Rewrite custom_completion::get_state() to use questionnaire::from_cm() and
  user_has_submitted() — removes raw DB calls and lib.php require_once

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mchurchward

classes/completion/custom_completion.php

@@ -20,10 +20,9 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-require_once($CFG->dirroot . '/mod/questionnaire/lib.php');
-
 use coding_exception;
 use core_completion\activity_custom_completion;
+use mod_questionnaire\questionnaire;
 use moodle_exception;
 
 /**
@@ -44,21 +43,9 @@ class custom_completion extends activity_custom_completion {
      * @return int
      */
     public function get_state(string $rule): int {
-        global $DB;
-
         $this->validate_rule($rule);
-        $userid = $this->userid;
-        $cm = $this->cm;
-
-        $questionnaire = $DB->get_record('questionnaire', ['id' => $cm->instance], '*', MUST_EXIST);
-
-        if ($questionnaire->completionsubmit) {
-            $params = ['userid' => $userid, 'questionnaireid' => $questionnaire->id, 'complete' => 'y'];
-            $status = $DB->record_exists('questionnaire_response', $params);
-        } else {
-            $status = false;
-        }
-
+        $questionnaire = questionnaire::from_cm($this->cm);
+        $status = $questionnaire->completionsubmit() && $questionnaire->user_has_submitted($this->userid);
         return $status ? COMPLETION_COMPLETE : COMPLETION_INCOMPLETE;
     }
 

classes/local/db/response_record.php

@@ -82,4 +82,18 @@ public static function get_for_questionnaire(int $questionnaireid): array {
     public static function get_complete_for_user(int $questionnaireid, int $userid): array {
         return static::get_records(['questionnaireid' => $questionnaireid, 'userid' => $userid, 'complete' => 'y']);
     }
+
+    /**
+     * True if the given user has at least one complete response for the given questionnaire.
+     *
+     * @param int $questionnaireid
+     * @param int $userid
+     * @return bool
+     */
+    public static function user_has_complete_response(int $questionnaireid, int $userid): bool {
+        return static::record_exists_select(
+            'questionnaireid = :questionnaireid AND userid = :userid AND complete = :complete',
+            ['questionnaireid' => $questionnaireid, 'userid' => $userid, 'complete' => 'y']
+        );
+    }
 }

classes/local/response/manager.php

@@ -561,6 +561,19 @@ public function response_check_format($section, $formdata, $checkmissing = true,
 
     // Static helpers — usable without a questionnaire instance.
 
+    /**
+     * True if the given user has at least one complete response for this questionnaire.
+     *
+     * @param int $userid
+     * @return bool
+     */
+    public function response_exists(int $userid): bool {
+        return \mod_questionnaire\local\db\response_record::user_has_complete_response(
+            $this->questionnaire->id,
+            $userid
+        );
+    }
+
     /**
      * Get all responses for a given questionnaire instance id and user, without needing an instance.
      * @param int $instanceid The questionnaire.id value.

classes/questionnaire.php

@@ -348,6 +348,15 @@ public function is_closed(): bool {
         return ($closedate > 0) ? ($closedate < time()) : false;
     }
 
+    /**
+     * True if the questionnaire is configured to require submission for completion.
+     *
+     * @return bool
+     */
+    public function completionsubmit(): bool {
+        return (bool) $this->modulerecord->get('completionsubmit');
+    }
+
     /**
      * True if the questionnaire collects anonymous responses.
      *
@@ -538,6 +547,16 @@ public function user_has_saved_response(int $userid): bool {
         );
     }
 
+    /**
+     * True if the given user has at least one complete (submitted) response for this questionnaire.
+     *
+     * @param int $userid
+     * @return bool
+     */
+    public function user_has_submitted(int $userid): bool {
+        return \mod_questionnaire\local\db\response_record::user_has_complete_response($this->id(), $userid);
+    }
+
     /**
      * Count the number of complete submissions for this questionnaire.
      *
@@ -1794,7 +1813,9 @@ public static function coursemodule_edit_post_actions(object $data, object $cour
      * @return bool True on success.
      */
     public static function delete_instance(int $id): bool {
-        global $DB;
+        global $CFG, $DB;
+        require_once($CFG->dirroot . '/mod/questionnaire/locallib.php');
+        require_once($CFG->dirroot . '/mod/questionnaire/questionnaire.class.php');
 
         if (!$questionnaire = $DB->get_record('questionnaire', ['id' => $id])) {
             return false;