Fixing final CI checks (#673)

* fix grunt amd.
* fix behat.
* Fix lang file.
* Full CI checks.
* Taking out of beta.
---------
Co-authored-by: Luca Bösch <luca.boesch@bfh.ch>

Author: mchurchward

.github/workflows/ci.yml

@@ -84,8 +84,7 @@ jobs:
 
       - name: Moodle Code Checker
         if: ${{ always() }}
-        # run: moodle-plugin-ci phpcs --max-warnings 0
-        run: moodle-plugin-ci phpcs
+        run: moodle-plugin-ci phpcs --max-warnings 0
 
       - name: Moodle PHPDoc Checker
         if: ${{ always() }}
@@ -105,14 +104,12 @@ jobs:
 
       - name: Grunt
         if: ${{ always() }}
-        # run: moodle-plugin-ci grunt --max-warnings 0
-        run: moodle-plugin-ci grunt
+        run: moodle-plugin-ci grunt --max-lint-warnings 0
 
       - name: PHPUnit tests
         if: ${{ always() }}
         run: moodle-plugin-ci phpunit --fail-on-warning
 
       - name: Behat features
         if: ${{ always() }}
-        # run: moodle-plugin-ci behat --profile chrome --scss-deprecations
-        run: moodle-plugin-ci behat --profile chrome
+        run: moodle-plugin-ci behat --profile chrome --scss-deprecations

amd/build/table_sort.min.js.map

@@ -52,27 +52,39 @@ define(['jquery'], function($) {
                 $(this).addClass('asc').removeClass('desc');
             }
             var arrData = $(this).closest('table').find('tbody >tr:has(td.cell)').get();
-            arrData.sort(function (a, b) {
+            arrData.sort(function(a, b) {
                 var val1 = $(a).children('td').eq(col).text();
                 var val2 = $(b).children('td').eq(col).text();
                 // Regex to check for date sorting.
                 var dateregx = /^\d{2}.*\d{4},/;
                 if (dateregx.test(val1) && dateregx.test(val2)) {
                     val1 = new Date(val1);
                     val2 = new Date(val2);
-                    return (val1 < val2) ? -sortOrder : (val1 > val2) ? sortOrder : 0;
+                    if (val1 < val2) {
+                        return -sortOrder;
+                    } else if (val1 > val2) {
+                        return sortOrder;
+                    } else {
+                        return 0;
+                    }
                 } else if ($.isNumeric(val1) && $.isNumeric(val2)) {
                     return sortOrder == 1 ? val1 - val2 : val2 - val1;
                 } else {
-                    return (val1 < val2) ? -sortOrder : (val1 > val2) ? sortOrder : 0;
+                    if (val1 < val2) {
+                        return -sortOrder;
+                    } else if (val1 > val2) {
+                        return sortOrder;
+                    } else {
+                        return 0;
+                    }
                 }
             });
             /* Append the sorted rows to tbody*/
-            $.each(arrData, function (index, row) {
+            $.each(arrData, function(index, row) {
                 var tableid = $('#' + id + ' tbody');
                 tableid.append(row);
             });
         },
     };
     return t;
-});
+});

amd/src/table_sort.js

@@ -385,7 +385,7 @@ public function print_preview_formend($url, $submitstr, $resetstr) {
         $output .= \html_writer::empty_tag('input', ['type' => 'submit', 'name' => 'submit', 'value' => $submitstr,
             'class' => 'btn btn-primary']);
         $output .= ' ';
-        $output .= \html_writer::tag('a', $resetstr, ['href' => $url, 'class' => 'btn btn-secondary mr-1']);
+        $output .= \html_writer::tag('a', $resetstr, ['href' => $url, 'class' => 'btn btn-secondary me-1']);
         $output .= \html_writer::end_tag('div') . "\n";
         $output .= \html_writer::end_tag('form') . "\n";
         return $output;