Questionnaire\Accessibility\Rate: table does not have a programmatically associated caption (#497)

* Questionnaire: More meaningful error than nopermissions (#488)

Co-authored-by: Emanoil Manoylov <[email protected]>

* Questionnaire\Accessibility\Rate: table does not have a programmatically associated caption

---------

Co-authored-by: emanoylov <[email protected]>
Co-authored-by: Emanoil Manoylov <[email protected]>
Co-authored-by: lamtranb <[email protected]>

Author: 4 people

classes/question/rate.php

@@ -198,6 +198,7 @@ public function get_feedback_maxscore() {
     protected function question_survey_display($response, $descendantsdata, $blankquestionnaire=false) {
         $choicetags = new \stdClass();
         $choicetags->qelements = [];
+        $choicetags->qelements['caption'] = strip_tags($this->content);
 
         $disabled = '';
         if ($blankquestionnaire) {

templates/question_rate.mustache

@@ -46,6 +46,7 @@
                         }
                     ]
                 },
+                "caption": "text",
                 "rows": [
                     {
                         "cols": [
@@ -123,6 +124,7 @@
 <!-- Begin HTML generated from question_rate template. -->
 {{#qelements}}
 <table style="width:{{twidth}}">
+  <caption class="accesshide">{{caption}}</caption>
   <tbody>
     {{#qelements.headerrow}}
     <tr>

tests/behat/rate_question_na.feature

@@ -60,3 +60,41 @@ Feature: Rate scale questions have options for displaing "N/A"
     Then I should see "Test questionnaire"
     And I should see "Rate these movies from 1 to 5"
     And I should see "N/A"
+
+  @javascript
+  Scenario: Test caption of table
+    Given the following "users" exist:
+      | username | firstname | lastname | email |
+      | teacher1 | Teacher | 1 | [email protected] |
+      | student1 | Student | 1 | [email protected] |
+    And the following "courses" exist:
+      | fullname | shortname | category |
+      | Course 1 | C1 | 0 |
+    And the following "course enrolments" exist:
+      | user | course | role |
+      | teacher1 | C1 | editingteacher |
+      | student1 | C1 | student |
+    And the following "activities" exist:
+      | activity | name | description | course | idnumber |
+      | questionnaire | Test questionnaire | Test questionnaire description | C1 | questionnaire0 |
+    And I log in as "teacher1"
+    And I am on "Course 1" course homepage
+    And I follow "Test questionnaire"
+    And I navigate to "Questions" in current page administration
+    And I add a "Rate (scale 1..5)" question and I fill the form with:
+      | Question Name | Q1 |
+      | Yes | y |
+      | Nb of scale items | 3 |
+      | Type of rate scale | No duplicate choices |
+      | Question Text | What are your top three movies? |
+      | Possible answers | Star Wars,Casablanca,Airplane,Citizen Kane,Anchorman |
+    Then I should see "position 1"
+    And I should see "[Rate (scale 1..5)] (Q1)"
+    And I should see "What are your top three movies?"
+    And I log out
+
+    And I log in as "student1"
+    And I am on "Course 1" course homepage
+    And I follow "Test questionnaire"
+    And I navigate to "Answer the questions..." in current page administration
+    Then "//caption[@class='accesshide' and text()='What are your top three movies?']" "xpath_element" should exist