Questionnaire: All branching shown in View your response (fixing code review)

Author: toanlamt

questionnaire.class.php

@@ -4196,8 +4196,11 @@ public static function get_user_identity_fields($context, $userid) {
     /**
      * Determines if a question is dependent on another question's choice.
      *
-     * Checks if the provided question has dependencies on other questions
-     * and if any required answer choices have not been selected.
+     * Check whether the given question depends on other question,
+     * and see if any answers have been provided for this question.
+     *
+     * If there is no answer to that question we assume that it was not answered
+     * because it depends on another choice and therefore is not displayed in the report.
      *
      * @param object $question The question object containing dependencies
      * @param array $answers   An associative array of answers with question IDs as keys
@@ -4206,10 +4209,8 @@ public static function get_user_identity_fields($context, $userid) {
      */
     public static function is_dependent_on_choices(object $question, array $answers): bool {
         if (!empty($question->dependencies)) {
-            foreach ($question->dependencies as $dependency) {
-                if (empty($answers[$dependency->dependquestionid][$dependency->dependchoiceid])) {
-                    return true;
-                }
+            if (empty($answers[$question->id])) {
+                return true;
             }
         }
         return false;