594 Fix formChild is null (#595)

When a student completed a questionnaire then shown the "Thank you for
completing this Questionnaire" page there was a JavaScript error:

  Uncaught TypeError: formChild is null

This was because the JavaScript for the questions form was being
inadvertently loaded for the Thank you page where this form is not
present.

Author: leonstr

classes/output/renderer.php

@@ -147,6 +147,7 @@ public function complete_formstart($action, $hiddeninputs=[]) {
         foreach ($hiddeninputs as $name => $value) {
             $output .= \html_writer::empty_tag('input', ['type' => 'hidden', 'name' => $name, 'value' => $value]) . "\n";
         }
+        $this->page->requires->js_init_call('M.mod_questionnaire.init_attempt_form', null, false, questionnaire_get_js_module());
         return $output;
     }
 

questionnaire.class.php

@@ -270,10 +270,6 @@ public function view() {
 
         $PAGE->set_title(format_string($this->name));
         $PAGE->set_heading(format_string($this->course->fullname));
-
-        // Initialise the JavaScript.
-        $PAGE->requires->js_init_call('M.mod_questionnaire.init_attempt_form', null, false, questionnaire_get_js_module());
-
         $message = $this->user_access_messages($USER->id, true);
         if ($message !== false) {
             $this->page->add_to_page('notifications', $message);