WIP3

Author: mchurchward

classes/edit_question_form.php

@@ -35,7 +35,6 @@
  * @property array _customdata
  */
 class edit_question_form extends \moodleform {
-
     /**
      * Form definition.
      */
@@ -75,7 +74,7 @@ public function validation($data, $files) {
                 $errors["length"] = get_string('notenoughscaleitems', 'questionnaire');
             }
             // If this is a rate question with no duplicates option.
-            if ($data['precise'] == 2 ) {
+            if ($data['precise'] == 2) {
                 $allchoices = $data['allchoices'];
                 $allchoices = explode("\n", $allchoices);
                 $nbvalues = 0;
@@ -92,8 +91,12 @@ public function validation($data, $files) {
 
         // If this is a slider question.
         if ($data['type_id'] == QUESSLIDER) {
-            if (isset($data['minrange']) && isset($data['maxrange']) && isset($data['startingvalue']) &&
-                    isset($data['stepvalue'])) {
+            if (
+                isset($data['minrange']) &&
+                isset($data['maxrange']) &&
+                isset($data['startingvalue']) &&
+                isset($data['stepvalue'])
+            ) {
                 if ($data['minrange'] >= $data['maxrange']) {
                     $errors['maxrange'] = get_string('invalidrange', 'questionnaire');
                 }
@@ -134,7 +137,7 @@ public function __get($name) {
         } else if ($name == '_customdata') {
             return $this->_customdata;
         } else {
-            throw new \coding_exception($name.' is not a publicly accessible property of '.get_class($this));
+            throw new \coding_exception($name . ' is not a publicly accessible property of ' . get_class($this));
         }
     }
 }

classes/event/all_responses_deleted.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class all_responses_deleted extends \core\event\base {
-
     /**
      * Init method.
      */

classes/event/all_responses_saved_as_text.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class all_responses_saved_as_text extends \core\event\base {
-
     /**
      * Init method.
      */
@@ -68,10 +67,9 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        $params = array();
+        $params = [];
         $params['action'] = 'vall';
         $params['group'] = $this->other['currentgroupid'];
         return new \moodle_url("/mod/questionnaire/report.php", $params);
     }
-
 }

classes/event/all_responses_viewed.php

@@ -40,7 +40,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class all_responses_viewed extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -75,7 +74,7 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        $params = array();
+        $params = [];
         $params['id'] = $this->contextinstanceid;
         if (isset($this->other['action'])) {
             $params['action'] = $this->other['action'];

classes/event/attempt_resumed.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class attempt_resumed extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -68,7 +67,6 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        return new \moodle_url("/mod/questionnaire/view.php", array('id' => $this->contextinstanceid));
+        return new \moodle_url("/mod/questionnaire/view.php", ['id' => $this->contextinstanceid]);
     }
-
 }

classes/event/attempt_saved.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class attempt_saved extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -67,7 +66,7 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        return new \moodle_url("/mod/questionnaire/view.php", array('id' => $this->contextinstanceid));
+        return new \moodle_url("/mod/questionnaire/view.php", ['id' => $this->contextinstanceid]);
     }
 
     /**

classes/event/attempt_submitted.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class attempt_submitted extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -67,7 +66,7 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        return new \moodle_url("/mod/questionnaire/view.php", array('id' => $this->contextinstanceid));
+        return new \moodle_url("/mod/questionnaire/view.php", ['id' => $this->contextinstanceid]);
     }
 
     /**

classes/event/course_module_viewed.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class course_module_viewed extends \core\event\course_module_viewed {
-
     /**
      * Set basic properties for the event.
      */

classes/event/non_respondents_viewed.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class non_respondents_viewed extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -68,9 +67,8 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        $params = array();
+        $params = [];
         $params['id'] = $this->contextinstanceid;
         return new \moodle_url("/mod/questionnaire/show_nonrespondents.php", $params);
     }
-
 }

classes/event/questionnaire_previewed.php

@@ -33,7 +33,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 class questionnaire_previewed extends \core\event\base {
-
     /**
      * Set basic properties for the event.
      */
@@ -67,9 +66,8 @@ public function get_description() {
      * @return \moodle_url
      */
     public function get_url() {
-        $params = array();
+        $params = [];
         $params['id'] = $this->contextinstanceid;
         return new \moodle_url("/mod/questionnaire/preview.php", $params);
     }
-
 }