For 3.10 release, fixing deprecated unit test functions.

Author: Mike Churchward

tests/csvexport_test.php

@@ -33,7 +33,7 @@
 
 class mod_questionnaire_csvexport_test extends advanced_testcase {
 
-    public function setUp() {
+    public function setUp(): void {
         global $CFG;
 
         require_once($CFG->dirroot.'/lib/testing/generator/data_generator.php');

tests/lib_test.php

@@ -51,7 +51,7 @@ public function test_questionnaire_supports() {
 
     public function test_questionnaire_get_extra_capabilities() {
         $caps = questionnaire_get_extra_capabilities();
-        $this->assertInternalType('array', $caps);
+        $this->assertIsArray($caps);
         $this->assertEquals(1, count($caps));
         $this->assertEquals('moodle/site:accessallgroups', reset($caps));
     }
@@ -231,11 +231,11 @@ public function test_questionnaire_get_user_grades() {
 
         // Test for an array when user specified.
         $grades = questionnaire_get_user_grades($questionnaire, $user->id);
-        $this->assertInternalType('array', $grades);
+        $this->assertIsArray($grades);
 
         // Test for an array when no user specified.
         $grades = questionnaire_get_user_grades($questionnaire);
-        $this->assertInternalType('array', $grades);
+        $this->assertIsArray($grades);
     }
 
     public function test_questionnaire_update_grades() {

tests/privacy_provider_test.php

@@ -40,7 +40,7 @@ class mod_questionnaire_privacy_testcase extends \core_privacy\tests\provider_te
     /**
      * Tests set up.
      */
-    public function setUp() {
+    public function setUp(): void {
         $this->resetAfterTest();
         $this->setAdminUser();
     }
@@ -123,7 +123,7 @@ public function test_export_user_data() {
         provider::export_user_data($approvedlist);
         $data = $writer->get_data([]);
 
-        $this->assertContains($questionnaire->name, strip_tags($data->name));
+        $this->assertStringContainsString($questionnaire->name, strip_tags($data->name));
         $this->assertEquals($questionnaire->intro, strip_tags($data->intro));
         $this->assertNotEmpty($data->responses[0]['questions']);
         $this->assertEquals('1. Text Box 1000', $data->responses[0]['questions'][1]->questionname);