[v4.1.1] [Moodle 4.4.6] [PHP 8.1] course/defaultcompletion.php - Form validation error when checking and saving with custom completion rule "submit"

[danowar2k]

Moodle 4.4 requires custom completion rules to have a suffix "_$modname".

When Moodle checks if automatic completion is enabled here: https://github.com/moodle/moodle/blob/b132ff1ed83dbe243909b8b121304ab20c0f069c/completion/classes/form/form_trait.php#L403

mod_questionnaire checks the given $data object only for the rule name without the suffix:

moodle-mod_questionnaire/mod_form.php

Lines 222 to 224 in 666310d

	public function completion_rule_enabled($data) {
	return !empty($data['completionsubmit']);
	}

while earlier it did create the form elements with the suffix:

moodle-mod_questionnaire/mod_form.php

Lines 211 to 214 in 666310d

	$mform =& $this->_form;
	$mform->addElement('checkbox', 'completionsubmit' . $suffix, '',
	get_string('completionsubmit', 'questionnaire'));
	return ['completionsubmit' . $suffix];

This leads to the bug that the custom completion rule can't be activated and therefore not be used (at least as a default)

[minhduchoang195]

I have already created a pull request #630 to solve this problem.