Skip to content

Commit 3fa2b69

Browse files
committed
fix: don't add or replace parts of the sprites' URL
1 parent 369d09f commit 3fa2b69

File tree

1 file changed

+1
-28
lines changed

1 file changed

+1
-28
lines changed

pokemon_v2/serializers.py

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1507,13 +1507,6 @@ def get_item_sprites(self, obj):
15071507
sprites_object = ItemSprites.objects.get(item_id=obj)
15081508
sprites_data = ItemSpritesSerializer(sprites_object, context=self.context).data
15091509
sprites_data = json.loads(sprites_data["sprites"])
1510-
host = "raw.githubusercontent.com/PokeAPI/sprites/master/"
1511-
1512-
for key in sprites_data:
1513-
if sprites_data[key]:
1514-
sprites_data[key] = (
1515-
"https://" + host + sprites_data[key].replace("/media/", "")
1516-
)
15171510

15181511
return sprites_data
15191512

@@ -2689,14 +2682,6 @@ def get_pokemon_form_sprites(self, obj):
26892682
).data
26902683
sprites_data = json.loads(sprites_data["sprites"])
26912684

2692-
host = "raw.githubusercontent.com/PokeAPI/sprites/master/"
2693-
2694-
for key in sprites_data:
2695-
if sprites_data[key]:
2696-
sprites_data[key] = (
2697-
"https://" + host + sprites_data[key].replace("/media/", "")
2698-
)
2699-
27002685
return sprites_data
27012686

27022687
def get_pokemon_form_types(self, obj):
@@ -2956,20 +2941,8 @@ def get_pokemon_sprites(self, obj):
29562941
sprites_data = PokemonSpritesSerializer(
29572942
sprites_object, context=self.context
29582943
).data
2959-
sprites_data = json.loads(sprites_data["sprites"])
2960-
host = "raw.githubusercontent.com/PokeAPI/sprites/master/"
2961-
2962-
def replace_sprite_url(d):
2963-
for key, value in d.items():
2964-
if isinstance(value, dict):
2965-
replace_sprite_url(value)
2966-
else:
2967-
if d[key]:
2968-
d[key] = "https://" + host + d[key].replace("/media/", "")
29692944

2970-
replace_sprite_url(sprites_data)
2971-
2972-
return sprites_data
2945+
return json.loads(sprites_data["sprites"])
29732946

29742947
def get_pokemon_moves(self, obj):
29752948

0 commit comments

Comments
 (0)